-
Notifications
You must be signed in to change notification settings - Fork 10.5k
AllocBoxToStack: Improve alloc_stack/dealloc_stack scoping #8411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci Please smoke test |
@swift-ci Please smoke benchmark |
+1! = D
Michael
… On Mar 29, 2017, at 10:19 AM, eeckstein ***@***.***> wrote:
@swift-ci <https://github.com/swift-ci> Please smoke benchmark
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#8411 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAee38n7bz9zG45REVl1OgGONo4MRDcTks5rqpKtgaJpZM4MtSiu>.
|
Build comment file:Optimized (O) Regression (11)
Improvement (4)
No Changes (276)
Regression (18)
Improvement (0)No Changes (273)
|
…nstructions in SIL. This is useful for optimizations (like AllocBoxToStack) which create (de-)alloc_stack instructions. They can just insert the new instructions anywhere without worrying about nesting and correct the nesting afterwards.
@swift-ci Please smoke test and merge |
1 similar comment
@swift-ci Please smoke test and merge |
Instead of inserting all alloc_stack/dealloc_stack instructions at the begin/end of the function, insert them at the actual lifetime boundaries. rdar://problem/16723128
@swift-ci Please smoke test and merge |
1 similar comment
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of inserting all alloc_stack/dealloc_stack instructions at the begin/end of the function, insert them at the actual lifetime boundaries.
rdar://problem/16723128