Remove Linux XFAIL in stdlib StringTraps tests #844
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezephir Do we need to import Foundation at all on OS X? |
|
@gribozavr Removing the import doesn't cause the tests to fail. I left it because I was concerned that importing Foundation might somehow subtly change what's being tested and I hadn't investigated further. Is it okay to remove it or is this something I need to look into further? |
|
@gribozavr I've looked into how things work some more and I feel better about removing the Foundation import on OS X. I've updated the PR with that change and rebased against master. Everything works on both platforms okay. |
Partially resolves SR-216.
gparker42
added a commit
that referenced
this pull request
Jan 5, 2016
Remove Linux XFAIL in stdlib StringTraps tests
|
Thanks for testing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves SR-216.
Tested on Ubuntu 14.04 and OS X 10.10