[TBDGen] Side-effects and asserts don't mix. #8446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test os x platform |
slavapestov
reviewed
Mar 31, 2017
lib/TBDGen/TBDGen.cpp
Outdated
| @@ -37,7 +37,8 @@ class TBDGenVisitor : public ASTVisitor<TBDGenVisitor> { | |||
| StringSet &Symbols; | |||
|
|
|||
| void addSymbol(StringRef name) { | |||
| assert(Symbols.insert(name).second && "already inserted"); | |||
| auto inserted = Symbols.insert(name).second; | |||
| assert(inserted && "already inserted"); | |||
There was a problem hiding this comment.
To avoid a warning with asserts off, add a (void) inserted; also
Fixes rdar://problem/31343022.
huonw
force-pushed
the
no-side-effects-in-asserts
branch
from
61a2b30 to
d710b46
Compare
|
@swift-ci Please smoke test and merge. |
4 similar comments
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/31343022.