Skip to content

Use the directory name, not full directory in SwiftBuildSupport.SWIFT_REPO_NAME #8455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Use the directory name, not full directory in SwiftBuildSupport.SWIFT_REPO_NAME #8455

merged 1 commit into from
Mar 31, 2017

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Mar 31, 2017

@gottesmm, from #8439

If this isn't correct, then I'll update the comments to fix #them.

The comments say:

Set SWIFT_REPO_NAME in your environment to control the name of the swift
directory name that is used.

However:

print(SWIFT_REPO_NAME)

C:\Users\hughb\Documents\GitHub\swift\swift

This is the full path, not the repo/directory name, which is not what this variable means.

@hughbe hughbe requested a review from gottesmm March 31, 2017 02:49
@hughbe
Copy link
Contributor Author

hughbe commented Mar 31, 2017

@swift-ci please clean smoke test

@gottesmm
Copy link
Contributor

@hughbe SGTM!

@gottesmm gottesmm merged commit 654f088 into swiftlang:master Mar 31, 2017
@hughbe hughbe deleted the build-support-fix-meanin branch April 1, 2017 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants