Skip to content

[runtime] Fix some casts of _SwiftValue #8457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2017
Merged

[runtime] Fix some casts of _SwiftValue #8457

merged 4 commits into from
Apr 10, 2017

Conversation

gparker42
Copy link
Contributor

  • Allow _SwiftValue to be cast to NSObject by yielding the box object itself.
  • Failed casts from NSDictionary containing _SwiftValue should not crash.

SR-4306, rdar://31197066

[runtime] Fix some casts of _SwiftValue.
61ba60f 
* Allow _SwiftValue to be cast to NSObject by yielding the box object itself.
* Failed casts from NSDictionary containing _SwiftValue should not crash.

SR-4306, rdar://31197066
@gparker42
Copy link
Contributor Author

WIP. Needs tests.

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 1, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 61ba60f
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Apr 1, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 61ba60f
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 489d9ff
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 489d9ff
Test requested by - @gparker42

Update LifetimeTracked.swift
8c1a188 
func == should be static
@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 6, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 489d9ff
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Apr 6, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 489d9ff
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

New test uncovered an additional bug; it fails in the same way with stock Swift.

@gparker42
Copy link
Contributor Author

Whew, not a real bug: the new test code provokes autorelease pool cruft in some configurations.

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 8, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 8c1a188
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Apr 8, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 8c1a188
Test requested by - @gparker42

@jckarter
Copy link
Contributor

jckarter commented Apr 8, 2017

Thanks @gparker42 !

@gparker42 gparker42 merged commit cfee4d9 into swiftlang:master Apr 10, 2017
@gparker42 gparker42 deleted the GrP-SR-4306 branch October 18, 2017 17:05
@gparker42 gparker42 restored the GrP-SR-4306 branch October 18, 2017 17:05
@gparker42 gparker42 deleted the GrP-SR-4306 branch November 10, 2017 04:35
@gparker42 gparker42 mannequin mentioned this pull request Mar 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gparker42 @swift-ci @jckarter