Fixing some questionable uses of Type::subst() #8497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftix
reviewed
Apr 3, 2017
lib/SILOptimizer/Utils/Generics.cpp
Outdated
| OriginalParamSubs = CallerParamSubs; | ||
|
|
||
| HasUnboundGenericParams = !SpecializedGenericSig->areAllParamsConcrete(); | ||
| createSubstitutedAndSpecializedTypes(); |
There was a problem hiding this comment.
Removing all this code from the constructor will break explicit specialization which is used by @_specialize (this constructor is invoked by the EagerSpecializer).
There was a problem hiding this comment.
That should be refactored to use the new methods you added though right?
There was a problem hiding this comment.
Probably, but explicit and automatic partial specializations have rather different setups. So, please leave this code there for now. I'll re-factor myself once we are there.
There was a problem hiding this comment.
Ok, I'll put it back and add a FIXME.
slavapestov
force-pushed
the
subst-fixes
branch
2 times, most recently
from
8956e08 to
1c05ae8
Compare
slavapestov
force-pushed
the
subst-fixes
branch
from
1c05ae8 to
b23624f
Compare
|
swiftlang/swift-corelibs-foundation#951 @swift-ci Please smoke test Linux |
slavapestov
force-pushed
the
subst-fixes
branch
from
b23624f to
3a4c0d8
Compare
|
@swift-ci Please smoke test |
Fix an odd corner case when UseErrorTypes was off; we would return the empty type if dependent member type substitution failed, but otherwise return the original type if it was a generic type parameter or an archetype. Now, if UseErrorTypes is off, return the empty type in both cases, even if the original type is 'primary'.
slavapestov
force-pushed
the
subst-fixes
branch
from
3a4c0d8 to
9319a53
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.