[Stdlib] Add a test for the performance of CollectionType.first #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,5 +202,41 @@ func testIsEmptyFirstLast() { | |||
| } | |||
| testIsEmptyFirstLast() | |||
|
|
|||
| /// A `CollectionType` that vends just the default implementations for | |||
| /// `CollectionType` methods. | |||
| struct CollectionOnly<T: CollectionType> : CollectionType { | |||
There was a problem hiding this comment.
This is Defaulted${traversal}Collection.
This tests the optimization commited in swiftlang#825.
lilyball
force-pushed
the
test-collectiontype-lazy-first-perf
branch
from
531b95c to
8cdaf4a
Compare
|
PR updated to use |
| // RUN: %target-run-simple-swift --stdlib-unittest-in-process | tee %t.txt | ||
| // RUN: FileCheck %s < %t.txt | ||
| // note: remove the --stdlib-unittest-in-process once all the FileCheck tests | ||
| // have been converted to StdlibUnittest |
There was a problem hiding this comment.
--stdlib-unittest-in-process is done because otherwise it repeats all of the non-StdlibUnittest tests in the child process, which causes duplicate output.
|
I see. Thank you! |
gribozavr
added a commit
that referenced
this pull request
Jan 4, 2016
…perf [Stdlib] Add a test for the performance of CollectionType.first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the optimization commited in #825.