Skip to content

python: Fix nosetests tests. #8608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2017
Merged

python: Fix nosetests tests. #8608

merged 1 commit into from
Apr 7, 2017

Conversation

erg
Copy link
Contributor

@erg erg commented Apr 7, 2017 •
edited
Loading

Why are the python reasons for having our code nested in a directory
called swift_build_support/swift_build_support/ instead of simply
swift_build_support/? Is that what we really want here?

#8389

All of the python tests and build-script broke after the above patch. Here are some fixes.

It also turns out we might not be running nosetests on PRs.

python: Fix nosetests tests.
c0b7918 
Why are the python reasons for having our code nested in a directory
called ``swift_build_support.swift_build_support/`` instead of simply
``swift_build_support/``? Is that what we really want here?
@erg erg requested a review from hughbe April 7, 2017 00:51
@erg
Copy link
Contributor Author

erg commented Apr 7, 2017

@swift-ci Please test

@erg
Copy link
Contributor Author

erg commented Apr 7, 2017

@swift-ci Please python lint

1 similar comment
@erg
Copy link
Contributor Author

erg commented Apr 7, 2017

@swift-ci Please python lint

@erg
Copy link
Contributor Author

erg commented Apr 7, 2017

@hughbe The change from python-lint to python_lint.py broke the CI python lint job. Ha!

@erg
Copy link
Contributor Author

erg commented Apr 7, 2017

@modocache Should we remove one level of swift_build_support directory nesting?

@erg erg merged commit f44e51b into swiftlang:master Apr 7, 2017
@erg
Copy link
Contributor Author

erg commented Apr 7, 2017

Merged to unbreak some things. Please keep chatting!

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c0b7918
Test requested by - @erg

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c0b7918
Test requested by - @erg

@hughbe
Copy link
Contributor

hughbe commented Apr 7, 2017

Oh yeah, I think that's because the CI runs Python limiting during a smoke test run now. I think it's also a good idea to remove the level of nesting

@shahmishal shahmishal mentioned this pull request Apr 7, 2017
Merged
@erg
Copy link
Contributor Author

erg commented Apr 7, 2017

Imo we should remove python tests from smoke tests and make a separate job for them that runs on every pr. Also we should make sure they work with nosetests and fox this include bug in build script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughbe hughbe Awaiting requested review from hughbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erg @swift-ci @hughbe