Skip to content

[scale-test] Diagnose exponential growth explicitly. #8635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Apr 8, 2017

This, somewhat questionably, fits the polynomial model and the
exponential model, and then chooses the one with the best R^2. However,
no matter how statistically valid this is, it works reasonably in
practice.

Slow growing things sometimes get classified as 1.0^n or 1.1^n, but
these are either spurious or not relevant, and so a similar thresholding
to the polynomial fit is used.

@huonw
Copy link
Contributor Author

huonw commented Apr 8, 2017

cc @rudkx

@huonw
Copy link
Contributor Author

huonw commented Apr 8, 2017

@swift-ci Please smoke test and merge.

Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thumbs up!

This, somewhat questionably, fits the polynomial model and the
exponential model, and then chooses the one with the best R^2. However,
no matter how statistically valid this is, it works reasonably in
practice.

Slow growing things sometimes get classified as 1.0^n or 1.1^n, but
these are either spurious or not relevant, and so a similar thresholding
to the polynomial fit is used.
@huonw
Copy link
Contributor Author

huonw commented Apr 10, 2017

@swift-ci Please smoke test and merge.

1 similar comment
@huonw
Copy link
Contributor Author

huonw commented Apr 10, 2017

@swift-ci Please smoke test and merge.

@huonw
Copy link
Contributor Author

huonw commented Apr 10, 2017

@swift-ci Please smoke test

@huonw huonw merged commit cd97248 into swiftlang:master Apr 10, 2017
@huonw huonw deleted the exp-scale-test branch April 10, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants