Skip to content

Leaks runner improvements #8674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2017

Conversation

gottesmm
Copy link
Contributor

This PR does two different things:

  1. It makes leaks runner support C-c.
  2. It makes leaks runner fail nicely when a subtask segfaults instead of just throwing an IndexError.

rdar://31544274

@gottesmm
Copy link
Contributor Author

@swift-ci python lint

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

@erg @shahmishal

Question. I ran python lint and it succeeded. Why is it also failing when performing smoke tests?

@gottesmm
Copy link
Contributor Author

*Why is it failing in the smoke tests when python lint succeeded on the bot.

@gottesmm gottesmm force-pushed the leaks_runner_improvements branch from 72bf5e7 to 92b7021 Compare April 10, 2017 23:35
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@shahmishal
Copy link
Member

smoke test has python lint test now:

FAIL: Swift(macosx-x86_64) :: Python/python-lint.swift (8776 of 9637)
******************** TEST 'Swift(macosx-x86_64) :: Python/python-lint.swift' FAILED ********************
Script:
--
/usr/bin/python /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--
./benchmark/scripts/Benchmark_RuntimeLeaksRunner.in:115:19: E128 continuation line under-indented for visual indent

--

********************

@shahmishal
Copy link
Member

*Why is it failing in the smoke tests when python lint succeeded on the bot.

Good question.

@gottesmm
Copy link
Contributor Author

@shahmishal I know. That is awesome = ). I am just asking why there is a discrepancy in between the two.

@swift-ci swift-ci merged commit 51e3917 into swiftlang:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants