Disable access_marker tests while I fix the ASAN failure. #8681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is obviously a silly iterator invalidation thing, but will require a little debugging.
|
@swift-ci smoke test and merge. |
|
Don't REQUIRES lines have to be valid identifiers now? |
|
@jrose-apple Do REQUIRES lines have requirements? |
|
It might only be in master-next, but then the master-next people will be upset with you. cc @compnerd , @bob-wilson |
|
Yeah, that will break. Can you remove the colon after "rdar" and put the other text on a separate comment line? |
|
@bob-wilson this was just for future reference. I already removed those lines this morning. Just been waiting on PR testing to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obviously a silly iterator invalidation thing, but will require a little
debugging.
https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/402/consoleFull