Add a SIL pass to select an access enforcement for allocated boxes. #8686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge. |
atrick
reviewed
Apr 11, 2017
| return setDynamicEnforcement(access); | ||
|
|
||
| // Otherwise, if there are no end_access instructions, | ||
| // check the terminators of every reachable block. |
There was a problem hiding this comment.
I'm not sure what "check the terminators" means" This code just checks if there are any uses reachable from this begin_access.
atrick
reviewed
Apr 11, 2017
There was a problem hiding this comment.
Nice, but this isn't quite what I expected:
There's extra complexity to handle begin_access markers that are not well-formed (no end_acces). What's that about, and how do you expect the SIL verifier to deal with it?
I actually expected most of the complexity to be in dealing with alloc_stack objects that escape via @inout_aliasable. It seems like you just assume those are statically verifiable. How do we know the noescape closure never causes simultaneous access to the captured variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to come.