Deserialization recovery for subscripts and properties with missing bases #8698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only handles cases where a subscript disappears wholesale; if one becomes read-only (for whatever terrible reason) the compiler will still crash.
Like the previous commit, but with added trickiness because we also serialize the form of the PatternBindingDecl a property came from. Make getPattern handle a failure in the simple case that overrides use, and pass that up to the PatternBindingDecl initialization. (This can result in zero-element PatternBindingDecls, but that's fine.) 'getPattern' is also a change from 'maybeGetPattern', but every caller knows how many patterns it expects, so accomodating the "maybe" case is no longer important.
|
@swift-ci Please smoke test |
jrose-apple
deleted the
deserialization-recovery-for-subscripts-and-vars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still fairly simple: it only handles a case where a subscript or property disappears or changes its type wholesale. If something happens to just the setter, we'll still consider it a fatal error and crash.
The only major remaining declaration kind that may be missing an override now is initializers. Those require more thought, however, since the presence or absence of initializers affects the behavior of subclasses.