AST/SILGen support for constant string literals #8701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://30545013
|
@swift-ci Please test |
|
Build failed |
|
Unrelated linux failure that also fails here: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/2577/ |
|
@swift-ci Please smoke test linux |
|
@aschwaighofer Can you also add support for an objc convention as well? This is important so we can take advantage of NSConstantString. Or did I miss it? |
|
Yes this could be done in the future. |
|
How do you express NSConstantString literals in swift? I don't think you can. |
|
@swift-ci Please test linux |
|
It would be done via an optimization. I.e. if we have a string literal and immediately bridge it to objc, we could replace it with an objc string literal that would get converted at IRGen time into an NSConstantString.
… On Apr 11, 2017, at 1:18 PM, Arnold Schwaighofer ***@***.***> wrote:
How do you express NSConstantString literals in swift? I don't think you can.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#8701 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAee36R_ExHhB9WUY3MEa8T4MXqjFKM0ks5ru-ABgaJpZM4M6fj6>.
|
|
@mgottesmm Good point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://30545013