Skip to content

[stdlib] One-sided ranges and RangeExpression #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2017
Merged

[stdlib] One-sided ranges and RangeExpression #8710

merged 5 commits into from
Apr 28, 2017

Conversation

airspeedswift
Copy link
Member

@airspeedswift airspeedswift commented Apr 11, 2017 •
edited
Loading

Migrates existing ClosedRange overloads to RangeExpressions.

@airspeedswift airspeedswift force-pushed the range-expression branch 4 times, most recently from d656e95 to 42ba7a7 Compare April 28, 2017 03:20
@airspeedswift airspeedswift changed the title [stdlib][WIP do not merge]One-sided ranges and RangeExpression [stdlib] One-sided ranges and RangeExpression Apr 28, 2017
@airspeedswift
Copy link
Member Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 42ba7a76a4a47e9e3404ad9a731a107ad015ac6e
Test requested by - @airspeedswift

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 42ba7a76a4a47e9e3404ad9a731a107ad015ac6e
Test requested by - @airspeedswift

@airspeedswift
Copy link
Member Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 68f4b1c8bbbf91cc4530a97317689afe5686876f
Test requested by - @airspeedswift

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 68f4b1c8bbbf91cc4530a97317689afe5686876f
Test requested by - @airspeedswift

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 17291d68a752398275746ac4931a4a4295d415cb
Test requested by - @airspeedswift

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test linux platform

@airspeedswift
Copy link
Member Author

@swift-ci please smoke benchmark

@airspeedswift
Copy link
Member Author

@swift-ci please clean smoke test linux platform

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

Build comment file:

Optimized (O)

Regression (9)
TEST OLD NEW DELTA SPEEDUP
ArrayInClass 60 68 +13.3% 0.88x (?)
MapReduceAnyCollection 306 333 +8.8% 0.92x
DropFirstAnySeqCRangeIterLazy 27163 29095 +7.1% 0.93x
ObjectiveCBridgeStubToNSDate 14163 15157 +7.0% 0.93x (?)
SortStringsUnicode 7501 8023 +7.0% 0.93x
ReversedDictionary 94 100 +6.4% 0.94x
Integrate 256 270 +5.5% 0.95x
DropFirstAnySeqCRangeIter 26951 28423 +5.5% 0.95x
Array2D 2037 2148 +5.4% 0.95x (?)
Improvement (7)
TEST OLD NEW DELTA SPEEDUP
SuffixArrayLazy 11 10 -9.1% 1.10x
PrefixArrayLazy 30 28 -6.7% 1.07x
StringHasPrefix 615 582 -5.4% 1.06x
PrefixAnySeqCntRange 116 110 -5.2% 1.05x
StaticArray 161 153 -5.0% 1.05x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 127640 121440 -4.9% 1.05x
HashTest 1711 1628 -4.9% 1.05x (?)
No Changes (253)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 2865 2874 +0.3% 1.00x (?)
AnyHashableWithAClass 66502 67803 +2.0% 0.98x (?)
ArrayAppend 737 731 -0.8% 1.01x (?)
ArrayAppendArrayOfInt 579 570 -1.6% 1.02x (?)
ArrayAppendAscii 19995 19403 -3.0% 1.03x (?)
ArrayAppendFromGeneric 597 580 -2.8% 1.03x
ArrayAppendGenericStructs 1203 1204 +0.1% 1.00x (?)
ArrayAppendLatin1 44414 45506 +2.5% 0.98x (?)
ArrayAppendLazyMap 995 979 -1.6% 1.02x (?)
ArrayAppendOptionals 1205 1169 -3.0% 1.03x
ArrayAppendRepeatCol 838 818 -2.4% 1.02x (?)
ArrayAppendReserved 517 506 -2.1% 1.02x (?)
ArrayAppendSequence 911 898 -1.4% 1.01x (?)
ArrayAppendStrings 13178 13179 +0.0% 1.00x (?)
ArrayAppendToFromGeneric 582 579 -0.5% 1.01x
ArrayAppendToGeneric 580 579 -0.2% 1.00x (?)
ArrayAppendUTF16 43176 42433 -1.7% 1.02x (?)
ArrayLiteral 1198 1198 +0.0% 1.00x
ArrayOfGenericPOD 213 213 +0.0% 1.00x
ArrayOfGenericRef 3922 3877 -1.1% 1.01x (?)
ArrayOfPOD 161 156 -3.1% 1.03x
ArrayOfRef 3817 3776 -1.1% 1.01x (?)
ArrayPlusEqualArrayOfInt 579 568 -1.9% 1.02x
ArrayPlusEqualFiveElementCollection 4427 4464 +0.8% 0.99x (?)
ArrayPlusEqualSingleElementCollection 754 758 +0.5% 0.99x
ArrayPlusEqualThreeElements 1598 1539 -3.7% 1.04x (?)
ArraySubscript 1480 1467 -0.9% 1.01x (?)
ArrayValueProp 5 5 +0.0% 1.00x
ArrayValueProp2 5 5 +0.0% 1.00x
ArrayValueProp3 5 5 +0.0% 1.00x
ArrayValueProp4 5 5 +0.0% 1.00x
BitCount 0 0 +0.0% 1.00x
ByteSwap 0 0 +0.0% 1.00x
CStringLongAscii 13501 13283 -1.6% 1.02x (?)
CStringLongNonAscii 4282 4220 -1.4% 1.01x (?)
CStringShortAscii 6106 6090 -0.3% 1.00x
Calculator 46 44 -4.3% 1.05x
CaptureProp 4731 4644 -1.8% 1.02x
CharacterLiteralsLarge 10381 10609 +2.2% 0.98x (?)
CharacterLiteralsSmall 756 758 +0.3% 1.00x (?)
Chars 1370 1363 -0.5% 1.01x (?)
ClassArrayGetter 12 12 +0.0% 1.00x
DeadArray 177 183 +3.4% 0.97x
Dictionary 832 860 +3.4% 0.97x
Dictionary2 2087 2091 +0.2% 1.00x (?)
Dictionary2OfObjects 3630 3636 +0.2% 1.00x (?)
Dictionary3 605 586 -3.1% 1.03x
Dictionary3OfObjects 1075 1058 -1.6% 1.02x (?)
DictionaryBridge 2853 2912 +2.1% 0.98x (?)
DictionaryLiteral 1463 1489 +1.8% 0.98x (?)
DictionaryOfObjects 2629 2642 +0.5% 1.00x (?)
DictionaryRemove 3639 3570 -1.9% 1.02x
DictionaryRemoveOfObjects 22725 22738 +0.1% 1.00x (?)
DictionarySwap 363 362 -0.3% 1.00x (?)
DictionarySwapOfObjects 6718 6802 +1.3% 0.99x
DropFirstAnyCollection 120 120 +0.0% 1.00x
DropFirstAnyCollectionLazy 42563 42693 +0.3% 1.00x (?)
DropFirstAnySeqCntRange 114 114 +0.0% 1.00x
DropFirstAnySeqCntRangeLazy 112 108 -3.6% 1.04x
DropFirstAnySequence 6414 6566 +2.4% 0.98x (?)
DropFirstAnySequenceLazy 6708 6722 +0.2% 1.00x (?)
DropFirstArray 29 28 -3.4% 1.04x (?)
DropFirstArrayLazy 33 33 +0.0% 1.00x
DropFirstCountableRange 22 22 +0.0% 1.00x
DropFirstCountableRangeLazy 22 22 +0.0% 1.00x
DropFirstSequence 2896 2896 +0.0% 1.00x
DropFirstSequenceLazy 2873 2885 +0.4% 1.00x (?)
DropLastAnyCollection 49 49 +0.0% 1.00x
DropLastAnyCollectionLazy 14436 14394 -0.3% 1.00x (?)
DropLastAnySeqCRangeIter 4427 4480 +1.2% 0.99x (?)
DropLastAnySeqCRangeIterLazy 4396 4480 +1.9% 0.98x
DropLastAnySeqCntRange 39 40 +2.6% 0.98x
DropLastAnySeqCntRangeLazy 39 40 +2.6% 0.98x
DropLastAnySequence 6495 6543 +0.7% 0.99x (?)
DropLastAnySequenceLazy 6273 6356 +1.3% 0.99x (?)
DropLastArray 10 10 +0.0% 1.00x
DropLastArrayLazy 10 10 +0.0% 1.00x
DropLastCountableRange 8 8 +0.0% 1.00x
DropLastCountableRangeLazy 8 8 +0.0% 1.00x
DropLastSequence 494 516 +4.5% 0.96x (?)
DropLastSequenceLazy 530 529 -0.2% 1.00x (?)
DropWhileAnyCollection 134 132 -1.5% 1.02x
DropWhileAnyCollectionLazy 93 92 -1.1% 1.01x (?)
DropWhileAnySeqCRangeIter 21782 22200 +1.9% 0.98x (?)
DropWhileAnySeqCRangeIterLazy 96 93 -3.1% 1.03x
DropWhileAnySeqCntRange 123 121 -1.6% 1.02x
DropWhileAnySeqCntRangeLazy 92 92 +0.0% 1.00x
DropWhileAnySequence 7274 7335 +0.8% 0.99x (?)
DropWhileAnySequenceLazy 2061 1983 -3.8% 1.04x
DropWhileArray 43 41 -4.7% 1.05x
DropWhileArrayLazy 77 77 +0.0% 1.00x
DropWhileCountableRange 35 35 +0.0% 1.00x
DropWhileCountableRangeLazy 75 75 +0.0% 1.00x
DropWhileSequence 2950 2877 -2.5% 1.03x
DropWhileSequenceLazy 63 63 +0.0% 1.00x
ErrorHandling 2842 2800 -1.5% 1.01x
GlobalClass 0 0 +0.0% 1.00x
Hanoi 3434 3585 +4.4% 0.96x
HashQuadratic 6300138 6269755 -0.5% 1.00x (?)
Histogram 245 244 -0.4% 1.00x (?)
IterateData 763 786 +3.0% 0.97x
Join 427 434 +1.6% 0.98x (?)
LazilyFilteredArrays 70325 70113 -0.3% 1.00x (?)
LazilyFilteredRange 6742 6681 -0.9% 1.01x (?)
LinkedList 6673 6657 -0.2% 1.00x
MapReduce 320 314 -1.9% 1.02x (?)
MapReduceAnyCollectionShort 1996 2066 +3.5% 0.97x (?)
MapReduceClass 3050 2967 -2.7% 1.03x (?)
MapReduceClassShort 4378 4364 -0.3% 1.00x (?)
MapReduceLazyCollection 15 15 +0.0% 1.00x
MapReduceLazyCollectionShort 44 45 +2.3% 0.98x
MapReduceLazySequence 85 85 +0.0% 1.00x
MapReduceSequence 448 445 -0.7% 1.01x (?)
MapReduceShort 1875 1844 -1.7% 1.02x (?)
MapReduceShortString 18 18 +0.0% 1.00x
MapReduceString 70 70 +0.0% 1.00x
Memset 226 233 +3.1% 0.97x (?)
MonteCarloE 9834 9832 -0.0% 1.00x (?)
MonteCarloPi 41623 41644 +0.1% 1.00x
NSDictionaryCastToSwift 5220 5220 +0.0% 1.00x
NSError 276 281 +1.8% 0.98x (?)
NSStringConversion 720 753 +4.6% 0.96x (?)
NopDeinit 26495 27440 +3.6% 0.97x
ObjectAllocation 181 177 -2.2% 1.02x (?)
ObjectiveCBridgeFromNSArrayAnyObject 22789 22863 +0.3% 1.00x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 4552 4453 -2.2% 1.02x
ObjectiveCBridgeFromNSArrayAnyObjectToString 43910 44478 +1.3% 0.99x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 38260 37973 -0.8% 1.01x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 4939 4901 -0.8% 1.01x (?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 105675 101560 -3.9% 1.04x
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 99989 97029 -3.0% 1.03x (?)
ObjectiveCBridgeFromNSSetAnyObject 65538 64699 -1.3% 1.01x (?)
ObjectiveCBridgeFromNSSetAnyObjectForced 4130 4121 -0.2% 1.00x (?)
ObjectiveCBridgeFromNSSetAnyObjectToString 78762 79984 +1.6% 0.98x (?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 74261 72150 -2.8% 1.03x (?)
ObjectiveCBridgeFromNSString 1423 1387 -2.5% 1.03x
ObjectiveCBridgeFromNSStringForced 2344 2369 +1.1% 0.99x (?)
ObjectiveCBridgeStubDataAppend 3671 3689 +0.5% 1.00x (?)
ObjectiveCBridgeStubDateAccess 182 177 -2.7% 1.03x
ObjectiveCBridgeStubDateMutation 265 260 -1.9% 1.02x
ObjectiveCBridgeStubFromArrayOfNSString 28017 27864 -0.5% 1.01x (?)
ObjectiveCBridgeStubFromNSDate 3745 3684 -1.6% 1.02x
ObjectiveCBridgeStubFromNSDateRef 3571 3637 +1.8% 0.98x (?)
ObjectiveCBridgeStubFromNSString 903 887 -1.8% 1.02x (?)
ObjectiveCBridgeStubFromNSStringRef 168 176 +4.8% 0.95x
ObjectiveCBridgeStubNSDataAppend 2297 2372 +3.3% 0.97x (?)
ObjectiveCBridgeStubNSDateMutationRef 12398 12827 +3.5% 0.97x (?)
ObjectiveCBridgeStubNSDateRefAccess 304 314 +3.3% 0.97x (?)
ObjectiveCBridgeStubToArrayOfNSString 28961 29376 +1.4% 0.99x (?)
ObjectiveCBridgeStubToNSDateRef 3355 3355 +0.0% 1.00x
ObjectiveCBridgeStubToNSString 1474 1458 -1.1% 1.01x (?)
ObjectiveCBridgeStubToNSStringRef 109 107 -1.8% 1.02x (?)
ObjectiveCBridgeStubURLAppendPath 247108 253426 +2.6% 0.98x
ObjectiveCBridgeStubURLAppendPathRef 251196 248649 -1.0% 1.01x (?)
ObjectiveCBridgeToNSArray 29600 29441 -0.5% 1.01x (?)
ObjectiveCBridgeToNSDictionary 62930 62064 -1.4% 1.01x (?)
ObjectiveCBridgeToNSSet 41087 40818 -0.7% 1.01x (?)
ObjectiveCBridgeToNSString 1263 1265 +0.2% 1.00x (?)
ObserverClosure 2218 2245 +1.2% 0.99x (?)
ObserverForwarderStruct 1046 1054 +0.8% 0.99x (?)
ObserverPartiallyAppliedMethod 3609 3627 +0.5% 1.00x (?)
ObserverUnappliedMethod 2717 2681 -1.3% 1.01x (?)
OpenClose 47 45 -4.3% 1.04x (?)
Phonebook 7493 7464 -0.4% 1.00x (?)
PolymorphicCalls 20 20 +0.0% 1.00x
PopFrontArray 1038 1054 +1.5% 0.98x (?)
PopFrontArrayGeneric 1081 1075 -0.6% 1.01x (?)
PopFrontUnsafePointer 8897 8806 -1.0% 1.01x
PrefixAnyCollection 123 123 +0.0% 1.00x
PrefixAnyCollectionLazy 43760 43684 -0.2% 1.00x (?)
PrefixAnySeqCRangeIter 21160 22162 +4.7% 0.95x
PrefixAnySeqCRangeIterLazy 21879 22120 +1.1% 0.99x (?)
PrefixAnySeqCntRangeLazy 112 109 -2.7% 1.03x
PrefixAnySequence 5895 5895 +0.0% 1.00x
PrefixAnySequenceLazy 5959 6025 +1.1% 0.99x
PrefixArray 29 29 +0.0% 1.00x
PrefixCountableRange 23 22 -4.3% 1.05x
PrefixCountableRangeLazy 22 22 +0.0% 1.00x
PrefixSequence 2490 2491 +0.0% 1.00x
PrefixSequenceLazy 2455 2455 +0.0% 1.00x
PrefixWhileAnyCollection 151 151 +0.0% 1.00x
PrefixWhileAnyCollectionLazy 73 73 +0.0% 1.00x
PrefixWhileAnySeqCRangeIter 11818 11876 +0.5% 1.00x (?)
PrefixWhileAnySeqCRangeIterLazy 73 74 +1.4% 0.99x (?)
PrefixWhileAnySeqCntRange 148 149 +0.7% 0.99x (?)
PrefixWhileAnySeqCntRangeLazy 75 73 -2.7% 1.03x
PrefixWhileAnySequence 13765 13261 -3.7% 1.04x
PrefixWhileAnySequenceLazy 1545 1532 -0.8% 1.01x (?)
PrefixWhileArray 64 64 +0.0% 1.00x
PrefixWhileArrayLazy 57 57 +0.0% 1.00x
PrefixWhileCountableRange 35 35 +0.0% 1.00x
PrefixWhileCountableRangeLazy 22 22 +0.0% 1.00x
PrefixWhileSequence 374 382 +2.1% 0.98x (?)
PrefixWhileSequenceLazy 36 37 +2.8% 0.97x (?)
Prims 747 750 +0.4% 1.00x (?)
ProtocolDispatch 2430 2356 -3.0% 1.03x (?)
ProtocolDispatch2 161 164 +1.9% 0.98x (?)
RC4 172 170 -1.2% 1.01x
RGBHistogram 2487 2479 -0.3% 1.00x (?)
RGBHistogramOfObjects 23534 23669 +0.6% 0.99x (?)
RangeAssignment 309 319 +3.2% 0.97x
RecursiveOwnedParameter 2271 2259 -0.5% 1.01x
ReversedArray 47 47 +0.0% 1.00x
ReversedBidirectional 45685 46755 +2.3% 0.98x
SetExclusiveOr 2718 2781 +2.3% 0.98x
SetExclusiveOr_OfObjects 9023 9161 +1.5% 0.98x (?)
SetIntersect 267 272 +1.9% 0.98x (?)
SetIntersect_OfObjects 1693 1674 -1.1% 1.01x (?)
SetIsSubsetOf 270 270 +0.0% 1.00x
SetIsSubsetOf_OfObjects 338 339 +0.3% 1.00x (?)
SetUnion 2487 2431 -2.3% 1.02x (?)
SetUnion_OfObjects 7677 7665 -0.2% 1.00x (?)
SevenBoom 1394 1421 +1.9% 0.98x (?)
Sim2DArray 271 266 -1.8% 1.02x (?)
SortLargeExistentials 7678 7887 +2.7% 0.97x
SortLettersInPlace 1100 1127 +2.5% 0.98x (?)
SortSortedStrings 873 859 -1.6% 1.02x (?)
SortStrings 1693 1737 +2.6% 0.97x (?)
StackPromo 21522 21942 +2.0% 0.98x (?)
StrComplexWalk 959 952 -0.7% 1.01x (?)
StrToInt 4743 4539 -4.3% 1.04x (?)
StringAdder 0 0 +0.0% 1.00x
StringBuilder 1266 1312 +3.6% 0.96x
StringBuilderLong 932 962 +3.2% 0.97x
StringEdits 413982 408149 -1.4% 1.01x (?)
StringEqualPointerComparison 7142 7265 +1.7% 0.98x (?)
StringHasPrefixUnicode 14642 14128 -3.5% 1.04x (?)
StringHasSuffix 683 658 -3.7% 1.04x (?)
StringHasSuffixUnicode 62127 60194 -3.1% 1.03x (?)
StringInterpolation 8305 8292 -0.2% 1.00x (?)
StringMatch 19772 19844 +0.4% 1.00x (?)
StringUTF16Builder 2059 2120 +3.0% 0.97x (?)
StringWalk 5717 5793 +1.3% 0.99x (?)
StringWithCString 303755 308242 +1.5% 0.99x (?)
SuffixAnyCollection 49 50 +2.0% 0.98x
SuffixAnyCollectionLazy 14209 14833 +4.4% 0.96x
SuffixAnySeqCRangeIter 4727 4930 +4.3% 0.96x
SuffixAnySeqCRangeIterLazy 4663 4788 +2.7% 0.97x
SuffixAnySeqCntRange 38 39 +2.6% 0.97x
SuffixAnySeqCntRangeLazy 39 38 -2.6% 1.03x
SuffixAnySequence 6497 6476 -0.3% 1.00x (?)
SuffixAnySequenceLazy 6285 6383 +1.6% 0.98x (?)
SuffixArray 10 10 +0.0% 1.00x
SuffixCountableRange 8 8 +0.0% 1.00x
SuffixCountableRangeLazy 8 8 +0.0% 1.00x
SuffixSequence 4179 4235 +1.3% 0.99x (?)
SuffixSequenceLazy 4323 4302 -0.5% 1.00x
SuperChars 270482 273142 +1.0% 0.99x (?)
TwoSum 881 877 -0.5% 1.00x (?)
TypeFlood 0 0 +0.0% 1.00x
UTF8Decode 273 280 +2.6% 0.98x
Walsh 337 347 +3.0% 0.97x (?)
XorLoop 349 342 -2.0% 1.02x
**Unoptimized (Onone)**
Regression (14)
TEST OLD NEW DELTA SPEEDUP
NSError 677 751 +10.9% 0.90x
ArrayAppendOptionals 1205 1319 +9.5% 0.91x
PrefixWhileAnyCollectionLazy 22198 24076 +8.5% 0.92x
PrefixWhileAnySeqCntRangeLazy 22437 24259 +8.1% 0.92x
ArrayAppendLazyMap 205029 220081 +7.3% 0.93x
PrefixCountableRangeLazy 38743 41525 +7.2% 0.93x
ObjectiveCBridgeFromNSSetAnyObjectToString 86371 92475 +7.1% 0.93x
ProtocolDispatch2 473 506 +7.0% 0.93x
DropLastAnySeqCntRangeLazy 6335 6760 +6.7% 0.94x
RGBHistogram 31732 33701 +6.2% 0.94x
RC4 18699 19823 +6.0% 0.94x
ArrayAppendReserved 3432 3617 +5.4% 0.95x
ObjectiveCBridgeStubToNSDate 14396 15164 +5.3% 0.95x (?)
HashQuadratic 48482503 51039923 +5.3% 0.95x
Improvement (6)
TEST OLD NEW DELTA SPEEDUP
ArrayAppendSequence 78916 71534 -9.4% 1.10x
ObjectiveCBridgeFromNSStringForced 2929 2705 -7.6% 1.08x
ObjectiveCBridgeStubFromNSString 1006 934 -7.2% 1.08x
ObjectiveCBridgeFromNSArrayAnyObjectToString 46895 44107 -5.9% 1.06x
ArrayPlusEqualThreeElements 11809 11134 -5.7% 1.06x (?)
OpenClose 425 402 -5.4% 1.06x
No Changes (249)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 2964 2947 -0.6% 1.01x (?)
AnyHashableWithAClass 81620 82508 +1.1% 0.99x (?)
Array2D 607490 592366 -2.5% 1.03x
ArrayAppend 3763 3891 +3.4% 0.97x
ArrayAppendArrayOfInt 658 659 +0.2% 1.00x (?)
ArrayAppendAscii 82770 84429 +2.0% 0.98x (?)
ArrayAppendFromGeneric 664 644 -3.0% 1.03x (?)
ArrayAppendGenericStructs 1235 1201 -2.8% 1.03x
ArrayAppendLatin1 102367 100129 -2.2% 1.02x
ArrayAppendRepeatCol 216615 213353 -1.5% 1.02x (?)
ArrayAppendStrings 13586 14233 +4.8% 0.95x
ArrayAppendToFromGeneric 643 661 +2.8% 0.97x
ArrayAppendToGeneric 627 645 +2.9% 0.97x
ArrayAppendUTF16 100068 101894 +1.8% 0.98x (?)
ArrayInClass 4473 4472 -0.0% 1.00x (?)
ArrayLiteral 1400 1417 +1.2% 0.99x (?)
ArrayOfGenericPOD 3094 3092 -0.1% 1.00x (?)
ArrayOfGenericRef 9194 9119 -0.8% 1.01x (?)
ArrayOfPOD 1741 1773 +1.8% 0.98x (?)
ArrayOfRef 8244 8309 +0.8% 0.99x (?)
ArrayPlusEqualArrayOfInt 643 623 -3.1% 1.03x
ArrayPlusEqualFiveElementCollection 281340 271191 -3.6% 1.04x (?)
ArrayPlusEqualSingleElementCollection 280405 291618 +4.0% 0.96x
ArraySubscript 4044 3930 -2.8% 1.03x
ArrayValueProp 2961 2860 -3.4% 1.04x (?)
ArrayValueProp2 3549 3547 -0.1% 1.00x (?)
ArrayValueProp3 3349 3419 +2.1% 0.98x
ArrayValueProp4 3243 3248 +0.2% 1.00x (?)
BitCount 852 853 +0.1% 1.00x (?)
ByteSwap 254 251 -1.2% 1.01x (?)
CStringLongAscii 12249 12844 +4.9% 0.95x
CStringLongNonAscii 4184 4140 -1.1% 1.01x (?)
CStringShortAscii 8818 8563 -2.9% 1.03x (?)
Calculator 1015 1006 -0.9% 1.01x (?)
CaptureProp 110254 109217 -0.9% 1.01x
CharacterLiteralsLarge 10691 10889 +1.9% 0.98x
CharacterLiteralsSmall 947 971 +2.5% 0.98x (?)
Chars 7174 7521 +4.8% 0.95x (?)
ClassArrayGetter 931 917 -1.5% 1.02x (?)
DeadArray 116272 115249 -0.9% 1.01x (?)
Dictionary 1956 1960 +0.2% 1.00x (?)
Dictionary2 3731 3834 +2.8% 0.97x
Dictionary2OfObjects 6001 6234 +3.9% 0.96x
Dictionary3 1454 1483 +2.0% 0.98x (?)
Dictionary3OfObjects 2270 2316 +2.0% 0.98x (?)
DictionaryBridge 2992 2961 -1.0% 1.01x (?)
DictionaryLiteral 12883 13112 +1.8% 0.98x (?)
DictionaryOfObjects 4750 4774 +0.5% 0.99x (?)
DictionaryRemove 20558 20719 +0.8% 0.99x (?)
DictionaryRemoveOfObjects 53821 53782 -0.1% 1.00x (?)
DictionarySwap 5427 5271 -2.9% 1.03x (?)
DictionarySwapOfObjects 18804 18898 +0.5% 1.00x (?)
DropFirstAnyCollection 19036 18671 -1.9% 1.02x (?)
DropFirstAnyCollectionLazy 138641 138967 +0.2% 1.00x (?)
DropFirstAnySeqCRangeIter 29603 30635 +3.5% 0.97x
DropFirstAnySeqCRangeIterLazy 29672 29871 +0.7% 0.99x
DropFirstAnySeqCntRange 19567 19852 +1.5% 0.99x (?)
DropFirstAnySeqCntRangeLazy 18940 19824 +4.7% 0.96x
DropFirstAnySequence 13927 13958 +0.2% 1.00x (?)
DropFirstAnySequenceLazy 13997 14620 +4.5% 0.96x (?)
DropFirstArray 6151 6099 -0.8% 1.01x (?)
DropFirstArrayLazy 44566 45419 +1.9% 0.98x (?)
DropFirstCountableRange 341 341 +0.0% 1.00x
DropFirstCountableRangeLazy 38427 39722 +3.4% 0.97x
DropFirstSequence 12719 13234 +4.0% 0.96x
DropFirstSequenceLazy 12905 13304 +3.1% 0.97x
DropLastAnyCollection 6434 6220 -3.3% 1.03x (?)
DropLastAnyCollectionLazy 47553 46769 -1.6% 1.02x
DropLastAnySeqCRangeIter 43654 43993 +0.8% 0.99x (?)
DropLastAnySeqCRangeIterLazy 43488 43817 +0.8% 0.99x (?)
DropLastAnySeqCntRange 6332 6599 +4.2% 0.96x
DropLastAnySequence 28991 28936 -0.2% 1.00x (?)
DropLastAnySequenceLazy 28588 28714 +0.4% 1.00x (?)
DropLastArray 2040 2019 -1.0% 1.01x (?)
DropLastArrayLazy 14734 14993 +1.8% 0.98x (?)
DropLastCountableRange 116 120 +3.4% 0.97x
DropLastCountableRangeLazy 12593 12771 +1.4% 0.99x (?)
DropLastSequence 27803 27912 +0.4% 1.00x (?)
DropLastSequenceLazy 28466 28304 -0.6% 1.01x (?)
DropWhileAnyCollection 24945 24833 -0.4% 1.00x (?)
DropWhileAnyCollectionLazy 26759 27343 +2.2% 0.98x
DropWhileAnySeqCRangeIter 31997 32854 +2.7% 0.97x (?)
DropWhileAnySeqCRangeIterLazy 27748 27210 -1.9% 1.02x (?)
DropWhileAnySeqCntRange 25523 25965 +1.7% 0.98x (?)
DropWhileAnySeqCntRangeLazy 27340 28161 +3.0% 0.97x
DropWhileAnySequence 16166 16469 +1.9% 0.98x
DropWhileAnySequenceLazy 12319 12643 +2.6% 0.97x
DropWhileArray 9520 9604 +0.9% 0.99x (?)
DropWhileArrayLazy 16544 15960 -3.5% 1.04x
DropWhileCountableRange 6190 6045 -2.3% 1.02x (?)
DropWhileCountableRangeLazy 26346 25968 -1.4% 1.01x (?)
DropWhileSequence 15701 15477 -1.4% 1.01x
DropWhileSequenceLazy 11094 11299 +1.8% 0.98x
ErrorHandling 3820 3666 -4.0% 1.04x
GlobalClass 0 0 +0.0% 1.00x
Hanoi 16641 16723 +0.5% 1.00x (?)
HashTest 18224 18291 +0.4% 1.00x (?)
Histogram 8483 8637 +1.8% 0.98x (?)
Integrate 388 394 +1.5% 0.98x (?)
IterateData 13400 13110 -2.2% 1.02x (?)
Join 1218 1213 -0.4% 1.00x (?)
LazilyFilteredArrays 2690520 2694689 +0.2% 1.00x (?)
LazilyFilteredRange 1291742 1258545 -2.6% 1.03x
LinkedList 31435 32285 +2.7% 0.97x (?)
MapReduce 36538 37009 +1.3% 0.99x
MapReduceAnyCollection 36378 36864 +1.3% 0.99x (?)
MapReduceAnyCollectionShort 49226 47434 -3.6% 1.04x
MapReduceClass 42121 41328 -1.9% 1.02x (?)
MapReduceClassShort 52493 51271 -2.3% 1.02x
MapReduceLazyCollection 31850 31154 -2.2% 1.02x
MapReduceLazyCollectionShort 43116 42134 -2.3% 1.02x (?)
MapReduceLazySequence 24640 24055 -2.4% 1.02x (?)
MapReduceSequence 40000 41526 +3.8% 0.96x
MapReduceShort 48684 50184 +3.1% 0.97x
MapReduceShortString 269 273 +1.5% 0.99x (?)
MapReduceString 2554 2529 -1.0% 1.01x (?)
Memset 41638 41520 -0.3% 1.00x (?)
MonteCarloE 131032 129154 -1.4% 1.01x (?)
MonteCarloPi 49815 50311 +1.0% 0.99x
NSDictionaryCastToSwift 6282 6485 +3.2% 0.97x
NSStringConversion 1327 1348 +1.6% 0.98x (?)
NopDeinit 50327 51875 +3.1% 0.97x
ObjectAllocation 633 631 -0.3% 1.00x (?)
ObjectiveCBridgeFromNSArrayAnyObject 24800 25247 +1.8% 0.98x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 7769 7659 -1.4% 1.01x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 40113 39419 -1.7% 1.02x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 126067 130203 +3.3% 0.97x
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 7510 7317 -2.6% 1.03x
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 110080 111187 +1.0% 0.99x
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 102373 104418 +2.0% 0.98x (?)
ObjectiveCBridgeFromNSSetAnyObject 66732 66561 -0.3% 1.00x (?)
ObjectiveCBridgeFromNSSetAnyObjectForced 7046 7093 +0.7% 0.99x (?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 77681 76068 -2.1% 1.02x (?)
ObjectiveCBridgeFromNSString 4115 4044 -1.7% 1.02x (?)
ObjectiveCBridgeStubDataAppend 4099 4056 -1.0% 1.01x (?)
ObjectiveCBridgeStubDateAccess 1001 1008 +0.7% 0.99x (?)
ObjectiveCBridgeStubDateMutation 530 515 -2.8% 1.03x
ObjectiveCBridgeStubFromArrayOfNSString 28724 29329 +2.1% 0.98x (?)
ObjectiveCBridgeStubFromNSDate 4041 4045 +0.1% 1.00x (?)
ObjectiveCBridgeStubFromNSDateRef 3979 3968 -0.3% 1.00x (?)
ObjectiveCBridgeStubFromNSStringRef 218 210 -3.7% 1.04x (?)
ObjectiveCBridgeStubNSDataAppend 2676 2725 +1.8% 0.98x (?)
ObjectiveCBridgeStubNSDateMutationRef 15749 15596 -1.0% 1.01x (?)
ObjectiveCBridgeStubNSDateRefAccess 1180 1185 +0.4% 1.00x (?)
ObjectiveCBridgeStubToArrayOfNSString 28971 28815 -0.5% 1.01x (?)
ObjectiveCBridgeStubToNSDateRef 3254 3273 +0.6% 0.99x (?)
ObjectiveCBridgeStubToNSString 1495 1522 +1.8% 0.98x (?)
ObjectiveCBridgeStubToNSStringRef 144 145 +0.7% 0.99x (?)
ObjectiveCBridgeStubURLAppendPath 256042 256706 +0.3% 1.00x (?)
ObjectiveCBridgeStubURLAppendPathRef 251458 257057 +2.2% 0.98x (?)
ObjectiveCBridgeToNSArray 28906 29701 +2.8% 0.97x (?)
ObjectiveCBridgeToNSDictionary 61573 63599 +3.3% 0.97x (?)
ObjectiveCBridgeToNSSet 40860 41790 +2.3% 0.98x (?)
ObjectiveCBridgeToNSString 1272 1272 +0.0% 1.00x
ObserverClosure 6408 6413 +0.1% 1.00x (?)
ObserverForwarderStruct 4489 4514 +0.6% 0.99x (?)
ObserverPartiallyAppliedMethod 7903 7760 -1.8% 1.02x (?)
ObserverUnappliedMethod 8250 8139 -1.3% 1.01x (?)
Phonebook 21817 21692 -0.6% 1.01x
PolymorphicCalls 3047 2933 -3.7% 1.04x
PopFrontArray 9850 9849 -0.0% 1.00x (?)
PopFrontArrayGeneric 8752 8954 +2.3% 0.98x (?)
PopFrontUnsafePointer 98648 96884 -1.8% 1.02x (?)
PrefixAnyCollection 19093 19235 +0.7% 0.99x (?)
PrefixAnyCollectionLazy 140826 139666 -0.8% 1.01x
PrefixAnySeqCRangeIter 23657 24721 +4.5% 0.96x
PrefixAnySeqCRangeIterLazy 23705 24637 +3.9% 0.96x
PrefixAnySeqCntRange 18758 19453 +3.7% 0.96x
PrefixAnySeqCntRangeLazy 18987 19821 +4.4% 0.96x
PrefixAnySequence 11411 11971 +4.9% 0.95x
PrefixAnySequenceLazy 11951 12364 +3.5% 0.97x
PrefixArray 6148 6023 -2.0% 1.02x (?)
PrefixArrayLazy 45425 44159 -2.8% 1.03x (?)
PrefixCountableRange 342 339 -0.9% 1.01x (?)
PrefixSequence 10984 11283 +2.7% 0.97x
PrefixSequenceLazy 10735 10934 +1.9% 0.98x (?)
PrefixWhileAnyCollection 37112 36943 -0.5% 1.00x
PrefixWhileAnySeqCRangeIter 40296 40804 +1.3% 0.99x
PrefixWhileAnySeqCRangeIterLazy 22287 22721 +1.9% 0.98x
PrefixWhileAnySeqCntRange 36305 37151 +2.3% 0.98x
PrefixWhileAnySequence 29497 28993 -1.7% 1.02x (?)
PrefixWhileAnySequenceLazy 11511 11643 +1.1% 0.99x (?)
PrefixWhileArray 16323 16505 +1.1% 0.99x
PrefixWhileArrayLazy 14263 14247 -0.1% 1.00x (?)
PrefixWhileCountableRange 17429 18144 +4.1% 0.96x
PrefixWhileCountableRangeLazy 21837 22816 +4.5% 0.96x
PrefixWhileSequence 28631 28816 +0.6% 0.99x (?)
PrefixWhileSequenceLazy 10363 10673 +3.0% 0.97x
Prims 8796 8786 -0.1% 1.00x (?)
ProtocolDispatch 6940 6750 -2.7% 1.03x
RGBHistogramOfObjects 95708 95920 +0.2% 1.00x (?)
RangeAssignment 5629 5622 -0.1% 1.00x (?)
RecursiveOwnedParameter 9135 9109 -0.3% 1.00x (?)
ReversedArray 565 568 +0.5% 0.99x (?)
ReversedBidirectional 145819 143056 -1.9% 1.02x (?)
ReversedDictionary 25234 25323 +0.4% 1.00x
SetExclusiveOr 20776 20962 +0.9% 0.99x (?)
SetExclusiveOr_OfObjects 40091 40980 +2.2% 0.98x
SetIntersect 10272 10397 +1.2% 0.99x
SetIntersect_OfObjects 10869 10818 -0.5% 1.00x (?)
SetIsSubsetOf 1577 1533 -2.8% 1.03x (?)
SetIsSubsetOf_OfObjects 1503 1509 +0.4% 1.00x (?)
SetUnion 11763 11878 +1.0% 0.99x (?)
SetUnion_OfObjects 28667 28474 -0.7% 1.01x (?)
SevenBoom 1526 1563 +2.4% 0.98x (?)
Sim2DArray 28577 28360 -0.8% 1.01x (?)
SortLargeExistentials 16932 16431 -3.0% 1.03x (?)
SortLettersInPlace 2846 2762 -3.0% 1.03x
SortSortedStrings 1422 1394 -2.0% 1.02x (?)
SortStrings 2776 2794 +0.6% 0.99x
SortStringsUnicode 9315 9324 +0.1% 1.00x (?)
StackPromo 99796 99784 -0.0% 1.00x (?)
StaticArray 4550 4582 +0.7% 0.99x (?)
StrComplexWalk 6144 6192 +0.8% 0.99x (?)
StrToInt 7941 8150 +2.6% 0.97x
StringAdder 45 46 +2.2% 0.98x
StringBuilder 2729 2769 +1.5% 0.99x (?)
StringBuilderLong 1131 1136 +0.4% 1.00x (?)
StringEdits 696403 694370 -0.3% 1.00x (?)
StringEqualPointerComparison 9566 9539 -0.3% 1.00x (?)
StringHasPrefix 1728 1698 -1.7% 1.02x (?)
StringHasPrefixUnicode 16083 16257 +1.1% 0.99x (?)
StringHasSuffix 1847 1866 +1.0% 0.99x (?)
StringHasSuffixUnicode 63613 65153 +2.4% 0.98x (?)
StringInterpolation 12009 12595 +4.9% 0.95x
StringMatch 41148 41886 +1.8% 0.98x (?)
StringUTF16Builder 3580 3612 +0.9% 0.99x (?)
StringWalk 22092 22005 -0.4% 1.00x (?)
StringWithCString 314538 313116 -0.5% 1.00x (?)
SuffixAnyCollection 6152 6154 +0.0% 1.00x (?)
SuffixAnyCollectionLazy 45475 45601 +0.3% 1.00x (?)
SuffixAnySeqCRangeIter 41613 41623 +0.0% 1.00x (?)
SuffixAnySeqCRangeIterLazy 39943 41661 +4.3% 0.96x
SuffixAnySeqCntRange 6309 6487 +2.8% 0.97x
SuffixAnySeqCntRangeLazy 6336 6662 +5.1% 0.95x
SuffixAnySequence 26730 26828 +0.4% 1.00x (?)
SuffixAnySequenceLazy 26141 26479 +1.3% 0.99x (?)
SuffixArray 2012 2024 +0.6% 0.99x (?)
SuffixArrayLazy 14818 14680 -0.9% 1.01x (?)
SuffixCountableRange 120 116 -3.3% 1.03x
SuffixCountableRangeLazy 12760 13009 +2.0% 0.98x (?)
SuffixSequence 26450 26764 +1.2% 0.99x
SuffixSequenceLazy 26325 26252 -0.3% 1.00x (?)
SuperChars 291582 290497 -0.4% 1.00x (?)
TwoSum 4229 4185 -1.0% 1.01x (?)
TypeFlood 162 161 -0.6% 1.01x (?)
UTF8Decode 36469 35953 -1.4% 1.01x
Walsh 11247 11292 +0.4% 1.00x (?)
XorLoop 22378 22405 +0.1% 1.00x
**Hardware Overview** Model Name: Mac mini Model Identifier: Macmini7,1 Processor Name: Intel Core i7 Processor Speed: 3 GHz Number of Processors: 1 Total Number of Cores: 2 L2 Cache (per Core): 256 KB L3 Cache: 4 MB Memory: 16 GB

@airspeedswift airspeedswift merged commit 946b776 into swiftlang:master Apr 28, 2017
@airspeedswift airspeedswift deleted the range-expression branch April 29, 2017 01:44
@aschwaighofer
Copy link
Contributor

@rudkx Commented that his bisection indicated that this might have broken:

https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185

aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Apr 30, 2017
@aschwaighofer
Revert "[stdlib] One-sided ranges and RangeExpression (swiftlang#8710)"
7d5d63e 
This reverts commit 946b776.
airspeedswift added a commit that referenced this pull request Apr 30, 2017
@airspeedswift
Revert "Revert "[stdlib] One-sided ranges and RangeExpression (#8710)""
3890376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airspeedswift @swift-ci @aschwaighofer