[SE-0160] Swift 3: Downgrade error about non-ObjC @(IB|GK)Inspectable properties #8772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properties @IBInspectable and @GKInspectable both work via the Objective-C runtime. SE-0160 made them imply @objc, but doing so made it an error to define an @IBInspectable or @GKInspectable property with a type that could not be expressed in Objective-C. The attribute is useless, but this broke Swift 3 code. So, downgrade the error to a warning in Swift 3 compatibility mode, with a Fix-It to remove the useless attribute. It remains an error in Swift 4. Fixes rdar://problem/31408971.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@IBInspectableand@GKInspectableboth work via the Objective-Cruntime. SE-0160 made them imply @objc, but doing so made it an error
to define an
@IBInspectableor@GKInspectableproperty with a typethat could not be expressed in Objective-C. The attribute is useless,
but this broke Swift 3 code.
So, downgrade the error to a warning in Swift 3 compatibility mode,
with a Fix-It to remove the useless attribute. It remains an error in
Swift 4.
Fixes rdar://problem/31408971.