[Serialization] Filter Objective-C methods by mangled name rather than type ID. #8838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n type ID. Module files store all of the Objective-C method entrypoints in a central table indexed by selector, then filter the results based on the specific class being requested. Rather than storing the class as a TypeID---which requires a bunch of deserialization---store its mangled name. This allows us to deserialize less, and causes circular deserialization in rdar://problem/31615640.
|
@swift-ci please smoke test and merge |
jrose-apple
reviewed
Apr 18, 2017
| std::make_tuple(owningTypeID, | ||
| func->isObjCInstanceMethod(), | ||
| S.addDeclRef(func))); | ||
| if (auto owningClass = |
There was a problem hiding this comment.
We only do this for classes (always have).
There was a problem hiding this comment.
Okay, then should this be an assertion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module files store all of the Objective-C method entrypoints in a
central table indexed by selector, then filter the results based on
the specific class being requested. Rather than storing the class as
a TypeID---which requires a bunch of deserialization---store its
mangled name. This allows us to deserialize less, and causes circular
deserialization in rdar://problem/31615640.