Bump Swift version to 4.0 #8861

tkremenek · 2017-04-19T18:48:20Z

rdar://problem/31899950

tkremenek · 2017-04-19T18:48:28Z

@swift-ci clean test

swift-ci · 2017-04-19T19:05:02Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - b7b9245
Test requested by - @tkremenek

tkremenek · 2017-04-19T19:18:12Z

@swift-ci clean test

swift-ci · 2017-04-19T19:18:32Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - b7b9245
Test requested by - @tkremenek

swift-ci · 2017-04-19T19:18:35Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b7b9245
Test requested by - @tkremenek

erg · 2017-04-19T19:24:59Z

@tkremenek The other place to change is in build-script:

    parser.add_argument(
        "--swift-user-visible-version",
        help="User-visible version of the embedded Swift compiler",
        type=arguments.type.swift_compiler_version,
        default="3.1", # change to 4.0
        metavar="MAJOR.MINOR")

Note: The build-script-impl version flag was made into dead code by a refactoring to python by someone else months ago, but I only removed it last week upon discovering it was dead.

tkremenek · 2017-04-19T20:02:35Z

@swift-ci clean test

swift-ci · 2017-04-19T20:02:57Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - dcc43ec
Test requested by - @tkremenek

swift-ci · 2017-04-19T20:02:57Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - dcc43ec
Test requested by - @tkremenek

jrose-apple

For now, we need to continue building the standard library and overlays with Swift 3 as well.

dabrahams · 2017-04-20T04:28:41Z

on Wed Apr 19 2017, Jordan Rose <notifications-AT-i.8713187.xyz> wrote:

For now, we need to continue building the standard library and overlays with Swift 3 as well.

That's a little alarming to hear; we've been under the impression that we could switch to building the standard library in Swift 4 mode whenever we want. Please explain why not, and when we can expect to be able to flip the switch. Thanks, -Dave

tkremenek · 2017-04-20T04:38:25Z

@dabrahams makes a good point. The intent is we want the Standard Library and overlays building in Swift 4 mode.

tkremenek · 2017-04-20T04:46:38Z

@DougGregor reminded me offline that the Standard Library/overlays can vend Swift 4 changes with @available markup. Let's review outside this PR whether we need to build these libraries in Swift 4 mode.

tkremenek · 2017-04-20T04:58:58Z

@swift-ci clean test

swift-ci · 2017-04-20T04:59:22Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 7c664d1
Test requested by - @tkremenek

swift-ci · 2017-04-20T04:59:22Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 7c664d1
Test requested by - @tkremenek

tkremenek · 2017-04-20T05:36:51Z

@swift-ci test linux

swift-ci · 2017-04-20T05:37:11Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 6106868
Test requested by - @tkremenek

tkremenek · 2017-04-20T06:34:48Z

Please test with following pull request:
swiftlang/swift-corelibs-foundation#956

@swift-ci test linux

swift-ci · 2017-04-20T06:42:54Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - d36b0b6
Test requested by - @tkremenek

tkremenek · 2017-04-20T07:08:26Z

Please test with following pull request:
swiftlang/swift-corelibs-xctest#188
swiftlang/swift-corelibs-foundation#956

@swift-ci test linux

swift-ci · 2017-04-20T07:13:03Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - d36b0b6
Test requested by - @tkremenek

tkremenek · 2017-04-20T07:17:51Z

Please test with following pull request:
swiftlang/swift-corelibs-xctest#188
swiftlang/swift-corelibs-foundation#956

@swift-ci test linux

tkremenek · 2017-04-28T06:20:56Z

@swift-ci clean test

swift-ci · 2017-04-28T06:21:17Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 157133d
Test requested by - @tkremenek

swift-ci · 2017-04-28T06:21:19Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 157133d
Test requested by - @tkremenek

This reverts commit 157133d.

… non-macOS platforms.

tkremenek · 2017-04-28T07:17:16Z

@swift-ci test

swift-ci · 2017-04-28T07:17:40Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ef98f2b
Test requested by - @tkremenek

swift-ci · 2017-04-28T07:17:42Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ef98f2b
Test requested by - @tkremenek

tkremenek · 2017-04-28T13:10:15Z

On Linux it looks like we are down to a test failure in swift-corelibs-Foundation:

TestFoundation/HTTPServer.swift:101:20: error: 'subscript' is unavailable
00:31:25             return str[startIndex..<endIndex]
00:31:25                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
00:31:25 Swift.String:3:12: note: 'subscript' was obsoleted in Swift 4
00:31:25     public subscript(bounds: Range<String.Index>) -> String { get }
00:31:25            ^
00:31:25 
TestFoundation/HTTPServer.swift:101:20: error: 'subscript' is unavailable
00:31:25             return str[startIndex..<endIndex]
00:31:25                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
00:31:25 Swift.String:3:12: note: 'subscript' was obsoleted in Swift 4
00:31:25     public subscript(bounds: Range<String.Index>) -> String { get }
00:31:25            ^

tkremenek · 2017-04-28T13:18:22Z

Please test with following pull request:
swiftlang/swift-corelibs-foundation#972

@swift-ci test linux

tkremenek · 2017-04-28T13:22:31Z

Also seeing on iphoneSimulator:

/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/test/DebugInfo/ErrorVar.swift:19:12: error: expected string not found in input
01:05:25  // CHECK: ![[ERRTY]] = !DICompositeType({{.*}}identifier: "_T0s5Error_pD"
01:05:25            ^
01:05:25 <stdin>:768:1: note: scanning from here
01:05:25 !90 = !DIExpression(DW_OP_deref)
01:05:25 ^
01:05:25 <stdin>:768:1: note: with variable "ERRTY" equal to "85"
01:05:25 !90 = !DIExpression(DW_OP_deref)
01:05:25 ^
01:05:25 <stdin>:773:3: note: possible intended match here
01:05:25 !95 = !DISubroutineType(types: !96)
01:05:25   ^
01:05:25

but this looks like a new, unrelated failure.

swift-ci · 2017-04-28T13:52:48Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 42ea938
Test requested by - @tkremenek

tkremenek · 2017-04-28T13:56:19Z

With:

swiftlang/swift-corelibs-foundation#972

the swift-corelibs-foundation tests pass. Now I am seeing the following test failure for swift-corelibs-xctest:

error: expression type 'XCTestCaseEntry' (aka '(testCaseClass: XCTestCase.Type, allTests: Array<(String, (XCTestCase) throws -> ())>)') is ambiguous without more context
06:52:46 XCTMain([testCase(MisuseTestCase.allTests)])
06:52:46          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
06:52:46

tkremenek · 2017-04-28T14:00:36Z

Please test with following pull request:
swiftlang/swift-corelibs-foundation#972
swiftlang/swift-corelibs-xctest#189

@swift-ci test linux

tkremenek · 2017-04-28T14:35:09Z

@swift-ci clean test

swift-ci · 2017-04-28T15:48:33Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 42ea938
Test requested by - @tkremenek

tkremenek · 2017-04-28T19:51:38Z

I think @adrian-prantl address the ErrorVar.swift failure in:

#9105

tkremenek · 2017-04-28T19:51:44Z

@swift-ci test macOS

swift-ci · 2017-04-28T20:58:37Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 42ea938
Test requested by - @tkremenek

tkremenek · 2017-04-28T21:03:48Z

I am seeing new test failures that appear unrelated. Looks like new breakage on master. Merging.

shajrawi · 2017-04-28T23:39:25Z

All the linux bots are failing with static_assert(SWIFT_VERSION_MAJOR == 4 in swift/lib/Basic/Version.cpp:329
looking at the build logs I see -DSWIFT_VERSION=3.1 -DSWIFT_VERSION_MAJOR=3 -DSWIFT_VERSION_MINOR=1

swiftix · 2017-04-28T23:41:35Z

@shajrawi You need a clean build to get rid of it

tkremenek · 2017-04-29T00:00:48Z

@shajrawi yeah sorry about that; apparently changing the version in the build-script doesn't reflect as a build dependency. I've triggered the bots to clean their workspaces.

adrian-prantl · 2017-04-29T03:33:29Z

AFAIK, this is an inherent limitation of CMake. Once configuration parameters are cached, they can only be reset by removing the CMake cache.

jrose-apple · 2017-05-02T16:00:04Z

Maybe we shouldn't be marking that variable as "CACHE"?

Bump Swift version to 4.0

b7b9245

Adjust to return compatibility version in Swift 3 mode.

dcc43ec

Bump default version in build script.

7c664d1

jrose-apple suggested changes Apr 19, 2017

View reviewed changes

Force -swift-version 3 for Standard Library and overlays.

6106868

Compile all standard library as Swift 3 mode.

d36b0b6

This was referenced Apr 20, 2017

Force use of Swift 3 compatibility mode to compile sources. swiftlang/swift-corelibs-foundation#956

Merged

Force use of -swift-version 3 to build XCTest sources. swiftlang/swift-corelibs-xctest#188

Merged

tkremenek added 2 commits April 28, 2017 00:11

Revert "Pass -swift-version X for %target-swift-frontend"

48eb937

This reverts commit 157133d.

Include config.swift_test_options in config.target_swift_frontend for…

42ea938

… non-macOS platforms.

tkremenek mentioned this pull request Apr 28, 2017

Force tests to build with -swift-version 3. swiftlang/swift-corelibs-xctest#189

Merged

tkremenek mentioned this pull request Apr 28, 2017

Force tests to build as Swift 3. swiftlang/swift-corelibs-foundation#972

Merged

tkremenek merged commit 749e05b into swiftlang:master Apr 28, 2017

tkremenek deleted the ver-4-bump branch April 29, 2017 00:02

bob-wilson mentioned this pull request May 16, 2017

[SR-3790] Update compiler version to 4.0 on master #46375

Closed

Bump Swift version to 4.0 #8861

Bump Swift version to 4.0 #8861

Uh oh!

Conversation

tkremenek commented Apr 19, 2017 • edited by najacque Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tkremenek commented Apr 19, 2017

Uh oh!

swift-ci commented Apr 19, 2017

Uh oh!

tkremenek commented Apr 19, 2017

Uh oh!

swift-ci commented Apr 19, 2017

Uh oh!

swift-ci commented Apr 19, 2017

Uh oh!

erg commented Apr 19, 2017

Uh oh!

tkremenek commented Apr 19, 2017

Uh oh!

swift-ci commented Apr 19, 2017

Uh oh!

swift-ci commented Apr 19, 2017

Uh oh!

jrose-apple left a comment

Choose a reason for hiding this comment

Uh oh!

dabrahams commented Apr 20, 2017 via email

Uh oh!

tkremenek commented Apr 20, 2017

Uh oh!

tkremenek commented Apr 20, 2017

Uh oh!

tkremenek commented Apr 20, 2017

Uh oh!

swift-ci commented Apr 20, 2017

Uh oh!

swift-ci commented Apr 20, 2017

Uh oh!

tkremenek commented Apr 20, 2017

Uh oh!

swift-ci commented Apr 20, 2017

Uh oh!

tkremenek commented Apr 20, 2017

Uh oh!

swift-ci commented Apr 20, 2017

Uh oh!

tkremenek commented Apr 20, 2017

Uh oh!

swift-ci commented Apr 20, 2017

Uh oh!

tkremenek commented Apr 20, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

swift-ci commented Apr 28, 2017

Uh oh!

swift-ci commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

swift-ci commented Apr 28, 2017

Uh oh!

swift-ci commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

swift-ci commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 28, 2017

Uh oh!

tkremenek commented Apr 19, 2017 •

edited by najacque

Loading