[stdlib] Add Swift 3 compatibility for String.init from old integer protocols #8926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
moiseev
reviewed
Apr 21, 2017
| @available(swift, obsoleted: 4) | ||
| public init<T : FixedWidthInteger>( | ||
| _ value: T, radix: Int = 10, uppercase: Bool = false | ||
| ) where T : SignedInteger { |
There was a problem hiding this comment.
What if you add this line to the non-obsolete version on FixedWIdthInteger?
There was a problem hiding this comment.
That would be detrimental to functionality, no? Someone who wants to write an extension on FixedWidthInteger that used this function would need to also constrain their function to either Signed or UnsignedInteger
|
Build failed |
airspeedswift
force-pushed
the
string-int-radix
branch
from
baf3037 to
9eda4e3
Compare
|
@swift-ci Please smoke test |
airspeedswift
added a commit
to airspeedswift/swift
that referenced
this pull request
Apr 22, 2017
airspeedswift
added a commit
that referenced
this pull request
Apr 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Swift-4-obsoleted versions that to signed/unsigned without them being fixed-width.
rdar://problem/31727219