[Serialization] Drop decls whose types can't be deserialized. #8933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
force-pushed
the
check-the-type-before-you-decl
branch
from
391ad61 to
5748ae8
Compare
|
@swift-ci Please smoke test |
The next commits will need access from ModuleFile.cpp. Also stop pretending we care what kind of error we got back, or that we might get back random other errors that weren't accounted for. That's good for crash logs, but not actually interesting here. (Nearly every place that previously looked for OverrideError will also accept the upcoming TypeError.) No effective functionality change.
Proof-of-concept for the above. This shouldn't be common---renames are far more likely, and those we can track---but occurs when the swift_wrapper attribute (the implementation of NS_STRING_ENUM) is active in Swift 4 but not in Swift 3. Note that this only checks the canonical interface type of the declaration, because the non-canonical type may contain references to the declaration's generic parameters.
If there's an error deserializing part of a type, just propagate it out. Also add support for bound generic types. This isn't meant to be full coverage of possible failures, just ones that are likely to come up through the C/ObjC importer. Still to do: - Generic function types (only show up on functions) - Unbound generic types (only show up on typealiases, which I may not even tackle)
This doesn't handle generic functions with problems in their requirements, but it's a step.
Finishes up the "big four" non-type decl kinds. Unfortunately, indiscriminately dropping members from a class affects the layout of its vtable. That issue is tracked by rdar://problem/31878396.
If a base method's not available, we already drop the overridding method. Make sure this works even when the base method is itself an override that failed to load.
jrose-apple
force-pushed
the
check-the-type-before-you-decl
branch
from
5748ae8 to
5344d16
Compare
|
@swift-ci Please smoke test |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be common—renames are far more likely, and those we can track—but occurs when the swift_wrapper attribute (the implementation of NS_STRING_ENUM) is active in Swift 4 but not in Swift 3.
Note that this only checks the canonical interface type of the declaration, because the non-canonical type may contain references to the declaration's generic parameters.