Fix the build mostly #8957
Merged
Fix the build mostly #8957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimizer was deleting the allocation altogether. Fixes one of the three failures outlined in <rdar://problem/31780356>.
…rchetypes This manifested as test/Prototypes/PatternMatching.swift failing under 'ninja check-swift-validation-optimize'. I'll add a test later if I have time to reduce a test case, but this whole hack is hopefully going away soon anyway. Fixes one of the three failures outlined in <rdar://problem/31780356>.
The SubstitutionMap type has a "null value" where there's no generic signature and no entries. There's nothing to dump in this case.
slavapestov
force-pushed
the
fix-the-build-mostly
branch
from
a7c8789 to
b4aaaee
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.