[index] Use a #pragma to apply module namespacing for exported ObjC header and match Swift namespaced USRs with the clang side #8972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eader and match Swift namespaced USRs with the clang side
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@jrose-apple , could you review the PrintAsObjC.cpp part ? |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
jrose-apple
reviewed
Apr 25, 2017
| @@ -2682,8 +2701,15 @@ class ModuleWriter { | |||
| out << | |||
| "#pragma clang diagnostic ignored \"-Wproperty-attribute-mismatch\"\n" | |||
| "#pragma clang diagnostic ignored \"-Wduplicate-method-arg\"\n" | |||
| "#if __has_warning(\"-Wpragma-clang-attribute\")\n" | |||
There was a problem hiding this comment.
Doesn't "pragma clang diagnostic ignored" already ignore unknown warnings?
There was a problem hiding this comment.
No, you get warning: unknown warning group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.