Fix SR-4659 Benchmark logs should be tied to tested tree version #8978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested changes
Apr 24, 2017
| `git_repo_path`""" | ||
| return subprocess.check_output( | ||
| ['git', '-C', git_repo_path, 'rev-parse', | ||
| '--short', 'HEAD'], stderr=subprocess.STDOUT).strip() |
There was a problem hiding this comment.
Can you use the full hash here? The reason why is that over time as history grows, a prefix collision becomes much more likely to happen. I have noticed this happen a few times with swift recently. It would be unfortunate if this was attached to a bug report and we could not tell the exact revision that it came from. That being said, I am not that wedded to this if you think I am being too paranoid.
There was a problem hiding this comment.
I didn't want to make the log filename overly long. Currently we have:
Benchmark_O-20170421004027.log
my change makes it:
Benchmark_O-20170422050121-077340abd7.log
full hash would be IMHO unwieldy:
Benchmark_O-20170422050121-f3b33f06d4c60f70afc591f2d261e7aac1c5d0ac.log
In SR-4675 "Report detailed build version from Benchmark drivers" I plan to report full hash and will add it into the report itself. So that will take care of that.
Also, there will be no conflicts with this - filename is still unique due to timestamp.
gottesmm
approved these changes
Apr 24, 2017
|
@swift-ci smoke benchmark |
Build comment file:Optimized (O) Regression (0)Improvement (0)No Changes (268)
Regression (0)Improvement (2)
No Changes (266)
|
|
@swift-ci smoke test and merge |
|
@gottesmm I’ve fixed the missing whitespace lint complained about, amended and force pushed. Can you smoke test and merge again, please? |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-4659.
Broken out of #8793.
@gottesmm Please review.