Prototype stateful Unicode decoding #8981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having looked at the old transcoding code, it's very clear that no stateless scheme has a hope of competing with it on performance. We just need reverse transcoding and a way to hook up indices (I believe we can use IndexingIterator for this, that's coming). This code demonstrates UTF-8 (the hard one) and is competitive on performance with the existing code. I believe it could be even better-performing if the cases that do parsing were connected directly with the cases that do decoding. Finally, tatoo this on your forehead: Dmitri Shall Not Be Underestimated
dabrahams
force-pushed
the
stateful-unicode-decoding
branch
from
efb6524 to
c2a92a6
Compare
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having looked at the old transcoding code, it's very clear that no stateless
scheme has a hope of competing with it on performance. We just need reverse
transcoding and a way to hook up indices (I believe we can use IndexingIterator
for this, that's coming).
This code demonstrates UTF-8 (the hard one) and is competitive on performance
with the existing code. I believe it could be even better-performing if the
cases that do parsing were connected directly with the cases that do decoding.
Finally, tatoo this on your forehead: Dmitri Shall Not Be Underestimated