[stdlib] BinaryInteger func word(at:) => var words: Words
#8984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please clean test linux platform |
dabrahams
reviewed
Apr 25, 2017
| @@ -1918,6 +1924,18 @@ extension BinaryInteger { | |||
| } | |||
| #endif | |||
|
|
|||
| extension BinaryInteger { | |||
| // FIXME(integers): inefficient. Should get rid of _word(at:) and | |||
| // countRepresentedWords, and make `words` the basic operation. | |||
There was a problem hiding this comment.
Do you want to use this to speed it up?
https://gist.github.com/dabrahams/976827a900b22689b09e14e7ffeecdcd
There was a problem hiding this comment.
I was thinking about CollectionOfOne<UInt>. But _UIntBuffer<UInt, UInt64> looks like a better solution for 32-bit platforms. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
wordsproperty toBinaryIntegerprotocol as described by SE-0104.