[ClangImporter] If enum_extensibility was removed, it's not an enum. #8992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and similar for flag_enum) This commit prepares the importer for a world in which NS_ENUM and NS_OPTIONS have adopted the new Clang attributes 'enum_extensibility' and 'flag_enum', but API notes are used to reverse the effect. Without this there would be no transition path for adopting the standard Cocoa macros, which have applied unconditionally up to now. rdar://problem/18744821
|
@swift-ci Please smoke test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Apr 25, 2017
…wiftlang#8992) (and similar for flag_enum) This commit prepares the importer for a world in which NS_ENUM and NS_OPTIONS have adopted the new Clang attributes 'enum_extensibility' and 'flag_enum', but API notes are used to reverse the effect. Without this there would be no transition path for adopting the standard Cocoa macros, which have applied unconditionally up to now. rdar://problem/18744821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and similar for flag_enum)
This commit prepares the importer for a world in which NS_ENUM and NS_OPTIONS have adopted the new Clang attributes
enum_extensibilityandflag_enum, but API notes are used to reverse the effect. Without this there would be no transition path for adopting the standard Cocoa macros, which have applied unconditionally up to now.rdar://problem/18744821