[GSB] Start inferring same-type requirements from inherited type declarations #9064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arations. Infer same-type requirements among same-named associated types/typealiases within inherited protocols. This is more staging; it doesn't really have teeth until we stop wiring together these types as part of lookup.
|
@swift-ci please smoke test and merge |
slavapestov
reviewed
Apr 27, 2017
| typealias->getUnderlyingTypeLoc().setInvalidType(Context); | ||
| } | ||
|
|
||
| typealias->setUnderlyingType( |
There was a problem hiding this comment.
What happens if it does have a generic parameter list? How is this different from the typealias case in validateDecl()?
There was a problem hiding this comment.
We punt on generic typealiases in protocols, which is (sadly) not new. It's different from the typealias case in validateDecl() because it's using the ProtocolRequirementTypeResolver. The fallback is just validateDecl().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer same-type requirements among same-named associated
types/typealiases within inherited protocols. This is more staging; it
doesn't really have teeth until we stop wiring together these types as
part of lookup.