Tbi fixes 4.0 branch #9076
Tbi fixes 4.0 branch #9076
Conversation
|
@swift-ci test |
|
Please just write this in SIL. |
|
(Background: Michael and I have been discussing this bug in quick bits and pieces these last few days. This "solution" is definitely too clever.) |
|
@jrose-apple At this point, I already have this done in a .swift file and I need to unblock some other people. At a later time, I am more than happy to convert this to .sil. |
|
This isn't even a good fix—the branch was only there because |
|
Build failed |
A few things here: 1. I changed the .swift file to be a .sil file. This one is for Jordan. It should also make the test not run into any issues due to swift level codegen changes. So we should have an even more robust test. 2. I fixed the watchossimulator test by eliminating any dependency of this test on an SDK. This is a pure compiler/target test. Just like the stdlib is not necessary, SDKs are not necessary either.
gottesmm
force-pushed
the
tbi_fixes_4.0_branch
branch
from
71b4644 to
e0a9c35
Compare
|
@jrose-apple I did it in SIL and fixed a few other issues... |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
|
Build failed |
|
Thank you! |
This PR contains fixes for the TBI test. It eliminates the stdlib dependencies so we will no longer have any issues related to deployment targets with this test. Since there are no more dependencies on having a stdlib, I was able to conditionalize the execution of the test on having the LLVM AArch64 code generator enabled. This ensures that normal builds will run this test, preventing further breakage.
rdar://24370377