Skip to content

[Serialization] Drop support for serializing LValueType. #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2017
Merged

[Serialization] Drop support for serializing LValueType. #9080

merged 1 commit into from
Apr 28, 2017

Conversation

jrose-apple
Copy link
Contributor

This type never appears in API boundaries or in SIL instructions, which means it never gets serialized.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 46d60a27086361556323352ab37034bb8472281d
Test requested by - @jrose-apple

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test macOS

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 46d60a27086361556323352ab37034bb8472281d
Test requested by - @jrose-apple

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test macOS

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 46d60a27086361556323352ab37034bb8472281d
Test requested by - @jrose-apple

slavapestov
slavapestov reviewed Apr 28, 2017
View reviewed changes
lib/Serialization/Deserialization.cpp
case decls_block::INOUT_TYPE: {
TypeID objectTypeID;
decls_block::LValueTypeLayout::readRecord(scratch, objectTypeID);
decls_block::InOutTypeLayout::readRecord(scratch, objectTypeID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, we were serializing INOUT_TYPE using LValueTypeLayout. Is this what's causing the test failure here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the test failure is completely unrelated. There's unfortunately no static or dynamic type-checking on the layout deserialization, although maybe there should be.

@jrose-apple
[Serialization] Drop support for serializing LValueType.
f7edba3 
This type never appears in API boundaries or in SIL instructions,
which means it never gets serialized.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test macOS

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 46d60a27086361556323352ab37034bb8472281d
Test requested by - @jrose-apple

@jrose-apple jrose-apple merged commit a9b6181 into swiftlang:master Apr 28, 2017
@jrose-apple jrose-apple deleted the lvalue-no-more branch April 28, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrose-apple @swift-ci @slavapestov