Skip to content

Enable subclass existentials #9090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2017
Merged

Enable subclass existentials #9090

merged 5 commits into from
Apr 28, 2017

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Apr 28, 2017 •
edited
Loading

Good enough for preliminary testing. Work that still remains:

  • The execution tests uncovered an unrelated optimizer bug (rdar://problem/31879356)
  • The SIL optimizer's devirtualization logic needs some small fixes to be able to devirtualize class methods on a subclass existential
  • Reflection, RemoteAST support for subclass existentials
  • Ripping out AnyObject
  • Class-constrained protocol composition types in associated type inheritance clauses
  • Protocols with superclass constraints on the conforming type

Fixes rdar://problem/23582191 and https://bugs.swift.org/browse/SR-4296.

@slavapestov slavapestov force-pushed the enable-subclass-existentials branch from 72229d1 to 5d76468 Compare April 28, 2017 02:58
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 5d764683e530899da465a83089cdd8a612c8188a
Test requested by - @slavapestov

@slavapestov slavapestov force-pushed the enable-subclass-existentials branch from 5d76468 to 6594a4c Compare April 28, 2017 03:46
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

I don't think this is my change:

ld: library not found for -lswiftCoreFoundation for architecture x86_64

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test macOS

@slavapestov slavapestov merged commit 0ad6f73 into swiftlang:master Apr 28, 2017
@slavapestov slavapestov mentioned this pull request Apr 28, 2017
Merged
@BasThomas BasThomas mentioned this pull request Apr 28, 2017
Closed
@slavapestov slavapestov mentioned this pull request Apr 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @swift-ci