SE-0169: Add support for shared private #9098
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,213 @@ | ||
| // RUN: %target-typecheck-verify-swift -swift-version 3 | ||
|
|
||
| class Container { | ||
| private func foo() {} // expected-note * {{declared here}} | ||
| private var bar = 0 // expected-note * {{declared here}} | ||
|
|
||
| private struct PrivateInner {} // expected-note * {{declared here}} | ||
|
|
||
| func localTest() { | ||
| foo() | ||
| self.foo() | ||
|
|
||
| _ = bar | ||
| bar = 5 | ||
| _ = self.bar | ||
| self.bar = 5 | ||
|
|
||
| privateExtensionMethod() // expected-error {{'privateExtensionMethod' is inaccessible due to 'private' protection level}} | ||
| self.privateExtensionMethod() // expected-error {{'privateExtensionMethod' is inaccessible due to 'private' protection level}} | ||
|
|
||
| _ = PrivateInner() | ||
| _ = Container.PrivateInner() | ||
| } | ||
|
|
||
| struct Inner { | ||
| func test(obj: Container) { | ||
| obj.foo() | ||
| _ = obj.bar | ||
| obj.bar = 5 | ||
| obj.privateExtensionMethod() // expected-error {{'privateExtensionMethod' is inaccessible due to 'private' protection level}} | ||
|
|
||
| _ = PrivateInner() | ||
| _ = Container.PrivateInner() | ||
| } | ||
|
|
||
| var inner: PrivateInner? // expected-error {{property must be declared private because its type uses a private type}} | ||
| var innerQualified: Container.PrivateInner? // expected-error {{property must be declared private because its type uses a private type}} | ||
| } | ||
|
|
||
| var inner: PrivateInner? // expected-error {{property must be declared private because its type uses a private type}} | ||
| var innerQualified: Container.PrivateInner? // expected-error {{property must be declared private because its type uses a private type}} | ||
| } | ||
|
|
||
| func test(obj: Container) { | ||
| obj.foo() // expected-error {{'foo' is inaccessible due to 'private' protection level}} | ||
| _ = obj.bar // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| obj.bar = 5 // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| obj.privateExtensionMethod() // expected-error {{'privateExtensionMethod' is inaccessible due to 'private' protection level}} | ||
|
|
||
| _ = Container.PrivateInner() // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| } | ||
|
|
||
| extension Container { | ||
| private func privateExtensionMethod() {} // expected-note * {{declared here}} | ||
|
|
||
| func extensionTest() { | ||
| foo() // expected-error {{'foo' is inaccessible due to 'private' protection level}} | ||
| self.foo() // expected-error {{'foo' is inaccessible due to 'private' protection level}} | ||
|
|
||
| _ = bar // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| bar = 5 // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| _ = self.bar // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| self.bar = 5 // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
|
|
||
| privateExtensionMethod() | ||
| self.privateExtensionMethod() | ||
|
|
||
| _ = PrivateInner() // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| _ = Container.PrivateInner() // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| } | ||
|
|
||
| // FIXME: Why do these errors happen twice? | ||
| var extensionInner: PrivateInner? { return nil } // expected-error 2 {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| var extensionInnerQualified: Container.PrivateInner? { return nil } // expected-error 2 {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| } | ||
|
|
||
| extension Container.Inner { | ||
| func extensionTest(obj: Container) { | ||
| obj.foo() // expected-error {{'foo' is inaccessible due to 'private' protection level}} | ||
| _ = obj.bar // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| obj.bar = 5 // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| obj.privateExtensionMethod() // expected-error {{'privateExtensionMethod' is inaccessible due to 'private' protection level}} | ||
|
|
||
| // FIXME: Unqualified lookup won't look into Container from here. | ||
| _ = PrivateInner() // expected-error {{use of unresolved identifier 'PrivateInner'}} | ||
| _ = Container.PrivateInner() // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| } | ||
|
|
||
| // FIXME: Why do these errors happen twice? | ||
| // FIXME: Unqualified lookup won't look into Container from here. | ||
| var inner: PrivateInner? { return nil } // expected-error 2 {{use of undeclared type 'PrivateInner'}} | ||
| var innerQualified: Container.PrivateInner? { return nil } // expected-error 2 {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| } | ||
|
|
||
| class Sub : Container { | ||
| func subTest() { | ||
| foo() // expected-error {{'foo' is inaccessible due to 'private' protection level}} | ||
| self.foo() // expected-error {{'foo' is inaccessible due to 'private' protection level}} | ||
|
|
||
| _ = bar // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| bar = 5 // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| _ = self.bar // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
| self.bar = 5 // expected-error {{'bar' is inaccessible due to 'private' protection level}} | ||
|
|
||
| privateExtensionMethod() // expected-error {{'privateExtensionMethod' is inaccessible due to 'private' protection level}} | ||
| self.privateExtensionMethod() // expected-error {{'privateExtensionMethod' is inaccessible due to 'private' protection level}} | ||
|
|
||
| _ = PrivateInner() // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| _ = Container.PrivateInner() // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| } | ||
|
|
||
| var subInner: PrivateInner? // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| var subInnerQualified: Container.PrivateInner? // expected-error {{'PrivateInner' is inaccessible due to 'private' protection level}} | ||
| } | ||
|
|
||
|
|
||
| protocol VeryImportantProto { | ||
| associatedtype Assoc | ||
| var value: Int { get set } // expected-note {{protocol requires property 'value' with type 'Int'; do you want to add a stub?}} | ||
| } | ||
|
|
||
| private struct VIPPrivateType : VeryImportantProto { | ||
| private typealias Assoc = Int // expected-error {{type alias 'Assoc' must be as accessible as its enclosing type because it matches a requirement in protocol 'VeryImportantProto'}} | ||
| var value: Int | ||
| } | ||
|
|
||
| private struct VIPPrivateProp : VeryImportantProto { | ||
| typealias Assoc = Int | ||
| private var value: Int // expected-error {{property 'value' must be as accessible as its enclosing type because it matches a requirement in protocol 'VeryImportantProto'}} {{3-10=fileprivate}} | ||
| } | ||
|
|
||
| private struct VIPPrivateSetProp : VeryImportantProto { | ||
| typealias Assoc = Int | ||
| private(set) var value: Int // expected-error {{setter for property 'value' must be as accessible as its enclosing type because it matches a requirement in protocol 'VeryImportantProto'}} {{3-10=fileprivate}} | ||
| } | ||
|
|
||
| private class VIPPrivateSetBase { | ||
| private var value: Int = 0 | ||
| } | ||
| private class VIPPrivateSetSub : VIPPrivateSetBase, VeryImportantProto { // expected-error {{type 'VIPPrivateSetSub' does not conform to protocol 'VeryImportantProto'}} | ||
| typealias Assoc = Int | ||
| } | ||
|
|
||
| private class VIPPrivateSetPropBase { | ||
| private(set) var value: Int = 0 // expected-error {{setter for property 'value' must be as accessible as its enclosing type because it matches a requirement in protocol 'VeryImportantProto'}} {{3-10=fileprivate}} | ||
| } | ||
| private class VIPPrivateSetPropSub : VIPPrivateSetPropBase, VeryImportantProto { | ||
| typealias Assoc = Int | ||
| } | ||
|
|
||
| extension Container { | ||
| private typealias ExtensionConflictingType = Int // expected-note * {{declared here}} | ||
| } | ||
| extension Container { | ||
| private typealias ExtensionConflictingType = Double // expected-note * {{declared here}} | ||
| } | ||
| extension Container { | ||
| func test() { | ||
| let a: ExtensionConflictingType? = nil // expected-error {{'ExtensionConflictingType' is inaccessible due to 'private' protection level}} | ||
| let b: Container.ExtensionConflictingType? = nil // expected-error {{'ExtensionConflictingType' is inaccessible due to 'private' protection level}} | ||
| _ = ExtensionConflictingType() // expected-error {{'ExtensionConflictingType' is inaccessible due to 'private' protection level}} | ||
| _ = Container.ExtensionConflictingType() // expected-error {{'ExtensionConflictingType' is inaccessible due to 'private' protection level}} | ||
| } | ||
| } | ||
|
|
||
| // All of these should be errors, but didn't have the correct behavior in Swift | ||
| // 3.0GM. | ||
| extension Container { | ||
| private struct VeryPrivateStruct { // expected-note * {{type declared here}} | ||
| private typealias VeryPrivateType = Int // expected-note * {{type declared here}} | ||
| var privateVar: VeryPrivateType { fatalError() } // expected-warning {{property should be declared private because its type uses a private type}} | ||
| var privateVar2 = VeryPrivateType() // expected-warning {{property should be declared private because its type 'Container.VeryPrivateStruct.VeryPrivateType' (aka 'Int') uses a private type}} | ||
| typealias PrivateAlias = VeryPrivateType // expected-warning {{type alias should be declared private because its underlying type uses a private type}} | ||
| subscript(_: VeryPrivateType) -> Void { return () } // expected-warning {{subscript should be declared private because its index uses a private type}} | ||
| func privateMethod(_: VeryPrivateType) -> Void {} // expected-warning {{method should be declared private because its parameter uses a private type}} {{none}} | ||
| enum PrivateRawValue: VeryPrivateType { // expected-warning {{enum should be declared private because its raw type uses a private type}} {{none}} | ||
| case A | ||
| } | ||
| enum PrivatePayload { | ||
| case A(VeryPrivateType) // expected-warning {{enum case in an internal enum uses a private type}} {{none}} | ||
| } | ||
|
|
||
| private class PrivateInnerClass {} // expected-note * {{declared here}} | ||
| class PrivateSuper: PrivateInnerClass {} // expected-warning {{class should be declared private because its superclass is private}} {{none}} | ||
| } | ||
|
|
||
| fileprivate var privateVar: VeryPrivateStruct { fatalError() } // expected-warning {{property should not be declared fileprivate because its type uses a private type}} {{none}} | ||
| fileprivate typealias PrivateAlias = VeryPrivateStruct // expected-warning {{type alias should not be declared fileprivate because its underlying type uses a private type}} {{none}} | ||
| fileprivate subscript(_: VeryPrivateStruct) -> Void { return () } // expected-warning {{subscript should not be declared fileprivate because its index uses a private type}} {{none}} | ||
| fileprivate func privateMethod(_: VeryPrivateStruct) -> Void {} // expected-warning {{method should not be declared fileprivate because its parameter uses a private type}} {{none}} | ||
| fileprivate enum PrivateRawValue: VeryPrivateStruct {} // expected-warning {{enum should not be declared fileprivate because its raw type uses a private type}} {{none}} | ||
| // expected-error@-1 {{raw type 'Container.VeryPrivateStruct' is not expressible by any literal}} | ||
| // expected-error@-2 {{'Container.PrivateRawValue' declares raw type 'Container.VeryPrivateStruct', but does not conform to RawRepresentable and conformance could not be synthesized}} | ||
| // expected-error@-3 {{RawRepresentable conformance cannot be synthesized because raw type 'Container.VeryPrivateStruct' is not Equatable}} | ||
| fileprivate enum PrivatePayload { | ||
| case A(VeryPrivateStruct) // expected-warning {{enum case in an internal enum uses a private type}} {{none}} | ||
| } | ||
|
|
||
| private class PrivateInnerClass {} // expected-note * {{declared here}} | ||
| fileprivate class PrivateSuperClass: PrivateInnerClass {} // expected-warning {{class should not be declared fileprivate because its superclass is private}} {{none}} | ||
| fileprivate class PrivateGenericUser<T> where T: PrivateInnerClass {} // expected-warning {{generic class should not be declared fileprivate because its generic requirement uses a private type}} {{none}} | ||
| } | ||
|
|
||
| fileprivate struct SR2579 { | ||
| private struct Inner { | ||
| private struct InnerPrivateType {} | ||
| var innerProperty = InnerPrivateType() // expected-warning {{property should be declared private because its type 'SR2579.Inner.InnerPrivateType' uses a private type}} | ||
| } | ||
| // FIXME: We need better errors when one access violation results in more | ||
| // downstream. | ||
| private var outerProperty = Inner().innerProperty // expected-warning {{property should not be declared in this context because its type 'SR2579.Inner.InnerPrivateType' uses a private type}} | ||
| var outerProperty2 = Inner().innerProperty // expected-warning {{property should be declared private because its type 'SR2579.Inner.InnerPrivateType' uses a private type}} | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: This doc comment
\seeshould probably be dropped or changed to\sa.