Skip to content

[Coverage] Emit a profiler increment in ObjC destructors #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2017
Merged

[Coverage] Emit a profiler increment in ObjC destructors #9108

merged 2 commits into from
Apr 29, 2017

Conversation

vedantk
Copy link
Contributor

@vedantk vedantk commented Apr 28, 2017

The compiler emits profiler increments in destructors for pure-Swift
classes, but not in destructors for classes that inherit from ObjC
classes. Add in increments for the second kind of destructor.

rdar://problem/29139109

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci Please smoke test

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

There was an unrelated build failure in CGBlocks.cpp. I think Akira just reverted the patch which caused the issue:

commit f6823351e17b694253e01936733c64b2495d8c21 (HEAD -> swift-4.0-branch, origin/swift-4.0-branch)
Author: Akira Hatanaka [email protected]
Date: Fri Apr 28 13:25:40 2017

Revert f258c834253f21918aaedbb256d6795556c70224.

It was causing bots to fail.

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

Actually, the build log says it has f6823351. I'll follow up with him.

@vedantk
[Coverage] Emit a profiler increment in ObjC destructors
ecae403 
The compiler emits profiler increments in destructors for pure-Swift
classes, but not in destructors for classes that inherit from ObjC
classes. Add in increments for the second kind of destructor.

rdar://problem/29139109
@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci Please smoke test

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci Please smoke test

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci Please smoke test Linux platform

1 similar comment
@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci Please smoke test Linux platform

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

Linux-only failure
'''
/home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/swift/lib/Basic/Version.cpp:329:5: error: static_assert failed "getCurrentLanguageVersion is no longer correct here"
static_assert(SWIFT_VERSION_MAJOR == 4,
^ ~~~~~~~~~~~~~~~~~~~~~~~~
'''

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci Please smoke test Linux platform

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci clean

@vedantk
Copy link
Contributor Author

vedantk commented Apr 28, 2017

@swift-ci clean smoke test linux

@vedantk vedantk merged commit e326728 into swiftlang:master Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vedantk