Skip to content

Add an assortment of new "always-on" metrics. #9110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Apr 28, 2017

This is a followup to #8477 with a bunch of additional metrics in the "always on" UnifiedStatsReporter class. These are intended either for CI-regression-prevention or helping users characterize performance problems in the field.

Note: by "always on" I mean always available in the build; they're not actually counted unless a user runs with -stats-output-dir.

@graydon
Copy link
Contributor Author

graydon commented Apr 28, 2017

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - b5292f0
Test requested by - @graydon

@graydon
Copy link
Contributor Author

graydon commented Apr 28, 2017

@swift-ci Please test platform Linux

@graydon
Copy link
Contributor Author

graydon commented Apr 28, 2017

@swift-ci Please test Linux Platform

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - b5292f0
Test requested by - @graydon

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b5292f0
Test requested by - @graydon

@graydon
Copy link
Contributor Author

graydon commented Apr 28, 2017

@swift-ci Please clean smoke test

@graydon graydon requested a review from rudkx April 28, 2017 22:20
@jrose-apple
Copy link
Contributor

Seems reasonable to me!

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@graydon graydon merged commit cd48479 into swiftlang:master Apr 28, 2017
@graydon graydon deleted the grab-bag-of-metrics branch September 13, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants