[ClangImporter] Don't infer 'Comparable' for swift_wrapper. #9120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying type's ordering may not be appropriate for the wrapped type (think an ordered list whose underlying type is NSString). Frameworks can always add a Comparable conformance explicitly. We squeak out of this being a source-breaking change by virtue of never having released a working version of it. Rintaro fixed the ambiguity problems back in f11b741, but that was after the last rebranch for Swift 3.1. rdar://problem/30166538
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci please clean smoke test Linux |
|
@swift-ci please smoke test macOS |
|
I didn't see what the failure was before the bots got reset. Hm. @swift-ci Please test macOS |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 2, 2017
…g#9120) The underlying type's ordering may not be appropriate for the wrapped type (think an ordered list whose underlying type is NSString). Frameworks can always add a Comparable conformance explicitly. We squeak out of this being a source-breaking change by virtue of never having released a working version of it. Rintaro fixed the ambiguity problems back in f11b741, but that was after the last rebranch for Swift 3.1. rdar://problem/30166538
jrose-apple
added a commit
that referenced
this pull request
May 3, 2017
…9202) The underlying type's ordering may not be appropriate for the wrapped type (think an ordered list whose underlying type is NSString). Frameworks can always add a Comparable conformance explicitly. We squeak out of this being a source-breaking change by virtue of never having released a working version of it. Rintaro fixed the ambiguity problems back in f11b741, but that was after the last rebranch for Swift 3.1. rdar://problem/30166538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying type's ordering may not be appropriate for the wrapped type (think an ordered list whose underlying type is NSString). Frameworks can always add a Comparable conformance explicitly.
We squeak out of this being a source-breaking change by virtue of never having released a working version of it. Rintaro fixed the ambiguity problems back in f11b741, but that was after the last rebranch for Swift 3.1.
rdar://problem/30166538