Skip to content

Fix the tbi test even harder. #9144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2017

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented May 1, 2017

A few things here:

  1. I changed the .swift file to be a .sil file. This one is for Jordan. It
    should also make the test not run into any issues due to swift level codegen
    changes. So we should have an even more robust test.

  2. I fixed the watchossimulator test by eliminating any dependency of this test
    on an SDK. This is a pure compiler/target test. Just like the stdlib is not
    necessary, SDKs are not necessary either.

rdar://24370377

A few things here:

1. I changed the .swift file to be a .sil file. This one is for Jordan. It
should also make the test not run into any issues due to swift level codegen
changes. So we should have an even more robust test.

2. I fixed the watchossimulator test by eliminating any dependency of this test
on an SDK. This is a pure compiler/target test. Just like the stdlib is not
necessary, SDKs are not necessary either.
@gottesmm
Copy link
Contributor Author

gottesmm commented May 1, 2017

@swift-ci test

@gottesmm gottesmm merged commit aa8d64c into swiftlang:master May 1, 2017
@gottesmm gottesmm deleted the fix_the_tbi_test_harder branch May 1, 2017 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant