-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[strip -ST] Disable runtime stack trace dumping on Darwin when asserts are disabled. #9170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
@swift-ci clean test |
Build failed |
Build failed |
This was the indirect argument failure. |
@swift-ci clean test |
Build failed |
Build failed |
Hmmm... lets try 1 more time. Hopefully Joe's fixes landed. |
@swift-ci clean test |
Build failed |
preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx |
fad03c7
to
a38e8ab
Compare
@swift-ci test |
@swiftix Can I get a review? |
@swift-ci test |
preset=buildbot,tools=RA,stdlib=RD |
@swift-ci test |
1 similar comment
@swift-ci test |
Build failed |
@gottesmm LGTM |
Build failed |
@swift-ci test |
1 similar comment
@swift-ci test |
The linux problem was due to an extra dependency that only comes up when you compile a static version of the stdlib. We weren't passing through the runtime flags to those static libraries (a bit scary). Happens only on linux. |
Build failed |
@swift-ci please clean test linux platform |
Build failed |
…s are disabled. This commit disables runtime stack trace dumping via dladdr on Darwin when asserts are disabled. This stack trace dumping was added as a way to improve the ability to debug the compiler for compiler developers. This is all well and good but having such a feature always enabled prevents us from reducing the size of the swift standard library by eliminating the swift nlist. rdar://31372220
@swift-ci Please clean smoke test linux platform |
1 similar comment
@swift-ci Please clean smoke test linux platform |
@swift-ci clean test os x platform |
Build failed |
[strip -ST] Disable runtime stack trace dumping on Darwin when asserts are disabled.
This commit disables runtime stack trace dumping via dladdr on Darwin when
stdlib asserts are disabled.
This stack trace dumping was added as a way to improve the ability to debug the
compiler for compiler developers. This is all well and good but having such a
feature always enabled prevents us from reducing the size of the swift standard
library by eliminating the swift nlist.
rdar://31372220