Skip to content

[strip -ST] Disable runtime stack trace dumping on Darwin when asserts are disabled. #9170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2017

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented May 1, 2017

[strip -ST] Disable runtime stack trace dumping on Darwin when asserts are disabled.

This commit disables runtime stack trace dumping via dladdr on Darwin when
stdlib asserts are disabled.

This stack trace dumping was added as a way to improve the ability to debug the
compiler for compiler developers. This is all well and good but having such a
feature always enabled prevents us from reducing the size of the swift standard
library by eliminating the swift nlist.

rdar://31372220

@gottesmm
Copy link
Contributor Author

gottesmm commented May 1, 2017

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented May 1, 2017

@swift-ci clean test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 5aadd31240534eaedb68906f0ff46b01078e5d99
Test requested by - @gottesmm

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 5aadd31240534eaedb68906f0ff46b01078e5d99
Test requested by - @gottesmm

@gottesmm
Copy link
Contributor Author

gottesmm commented May 2, 2017

This was the indirect argument failure.

@gottesmm
Copy link
Contributor Author

gottesmm commented May 2, 2017

@swift-ci clean test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 5aadd31240534eaedb68906f0ff46b01078e5d99
Test requested by - @gottesmm

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 5aadd31240534eaedb68906f0ff46b01078e5d99
Test requested by - @gottesmm

@gottesmm
Copy link
Contributor Author

gottesmm commented May 2, 2017

Hmmm... lets try 1 more time. Hopefully Joe's fixes landed.

@gottesmm
Copy link
Contributor Author

gottesmm commented May 2, 2017

@swift-ci clean test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 5aadd31240534eaedb68906f0ff46b01078e5d99
Test requested by - @gottesmm

@gottesmm
Copy link
Contributor Author

gottesmm commented May 2, 2017

preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx
@swift-ci Please test macOS with preset

@gottesmm gottesmm force-pushed the strip-st-fix branch 2 times, most recently from fad03c7 to a38e8ab Compare May 4, 2017 17:58
@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swiftix Can I get a review?

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

preset=buildbot,tools=RA,stdlib=RD
@swift-ci Please test macOS with preset

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci test

1 similar comment
@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - a38e8ab69134fe24878c79a558ef92957920a181
Test requested by - @gottesmm

@swiftix
Copy link
Contributor

swiftix commented May 4, 2017

@gottesmm LGTM

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 75af985ba5cc8f61cdc4ffee9c5088d5b19d71e6
Test requested by - @gottesmm

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci test

1 similar comment
@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

The linux problem was due to an extra dependency that only comes up when you compile a static version of the stdlib. We weren't passing through the runtime flags to those static libraries (a bit scary). Happens only on linux.

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - cba06c50fe0f7a18b9f5e99da776567bae80cebd
Test requested by - @gottesmm

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci please clean test linux platform

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - cba06c50fe0f7a18b9f5e99da776567bae80cebd
Test requested by - @gottesmm

…s are disabled.

This commit disables runtime stack trace dumping via dladdr on Darwin when
asserts are disabled.

This stack trace dumping was added as a way to improve the ability to debug the
compiler for compiler developers. This is all well and good but having such a
feature always enabled prevents us from reducing the size of the swift standard
library by eliminating the swift nlist.

rdar://31372220
@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci Please clean smoke test linux platform

1 similar comment
@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci Please clean smoke test linux platform

@gottesmm
Copy link
Contributor Author

gottesmm commented May 4, 2017

@swift-ci clean test os x platform

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - cba06c50fe0f7a18b9f5e99da776567bae80cebd
Test requested by - @gottesmm

@gottesmm gottesmm merged commit 77a85f8 into swiftlang:master May 5, 2017
@gottesmm gottesmm deleted the strip-st-fix branch May 5, 2017 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants