Fix an issue that was uncovered by the linux fix: resolves verifier bug in 32-bit code #9177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug in 32-bit code
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
shajrawi
pushed a commit
that referenced
this pull request
May 2, 2017
Fix an issue that was uncovered by the linux fix: resolves verifier bug in 32-bit code
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uncovered a problem on mac 32-bit targets #9165
It only shows up in a full build when trying to verify all SIL on 32-bit targets
This PR tries to resolve that issue: we fixed the substituted function type, but, the old deceleration does not make sense (because we changed the ABI) - don't verify against it if the SIL stage is lowered