Skip to content

Produce specialized conformances to AnyObject for bound generic types. #9181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2017

Conversation

swiftix
Copy link
Contributor

@swiftix swiftix commented May 2, 2017

Fixes rdar://31910351 (SR-4750)

@swiftix
Copy link
Contributor Author

swiftix commented May 2, 2017

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 7c4ee78
Test requested by - @swiftix

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 7c4ee78
Test requested by - @swiftix

@swiftix
Copy link
Contributor Author

swiftix commented May 2, 2017

@swift-ci please smoke test

@swiftix
Copy link
Contributor Author

swiftix commented May 2, 2017

@swift-ci please test

@swiftix
Copy link
Contributor Author

swiftix commented May 2, 2017

Explanation: Fixes the way how conformances to AnyObject are represented for bound generic types. It prevents a nullptr dereferencing bug during compile-time.

Scope: Fixes a nullptr dereferencing bug during compile-time in optimized builds

Issue: rdar://31910351 (SR-4750)

Risk: Low

Testing: Swift CI + dedicated test

@swiftix
Copy link
Contributor Author

swiftix commented May 2, 2017

Reviewed by @slavapestov on master already

@swiftix swiftix merged commit fddcd24 into swiftlang:swift-4.0-branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants