[4.0] [SE-0160] Make deprecated @objc inference warnings opt-in. #9183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings about deprecated @objc inference in Swift 3 mode can be a bit annoying; and are mostly relevant to the migration workflow. Make the warning emission a three-state switch: * None (the default): don't warn about these issues. * Minimal (-warn-swift3-objc-inference-minimal): warn about direct uses of @objc entrypoints and provide "@objc" Fix-Its for them. * Complete (-warn-swift3-objc-inference-complete): warn about all cases where Swift 3 infers @objc but Swift 4 will not. Fixes rdar://problem/31922278. (cherry picked from commit 66b11cb)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings about deprecated
@objcinference in Swift 3 mode can be abit annoying; and are mostly relevant to the migration workflow. Make
the warning emission a three-state switch:
-warn-swift3-objc-inference-minimal): warn about directuses of Objective-C entrypoints and provide
@objcFix-Its for them.-warn-swift3-objc-inference-complete): warn about allcases where Swift 3 infers
@objcbut Swift 4 will not.Fixes rdar://problem/31922278.
(cherry picked from commit 66b11cb)