Skip to content

Merge pull request #9098 from KingOfBrian/feature/SE-0169 #9213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2017
Merged

Merge pull request #9098 from KingOfBrian/feature/SE-0169 #9213

merged 1 commit into from
May 3, 2017

Conversation

ematejska
Copy link
Contributor

@ematejska ematejska commented May 3, 2017 •
edited by najacque
Loading

SE-0169: Add support for shared private(cherry picked from commit 75a1dca)

rdar://problem/31684646

Merge pull request #9098 from KingOfBrian/feature/SE-0169
32e7a1d 
SE-0169: Add support for shared private(cherry picked from commit 75a1dca)
@ematejska
Copy link
Contributor Author

@swift-ci test

@ematejska
Copy link
Contributor Author

@swift-ci Please Test Source Compatibility

@tkremenek
Copy link
Member

I thought this change was only for --swift-version 3, but we see FAIL: Kickstarter-ReactiveExtensions in the compatibility suite.

@ematejska
Copy link
Contributor Author

@swift-ci Please Test Source Compatibility

@ematejska
Copy link
Contributor Author

@tkremenek That's correct, it should only be in the Swift 3 mode. I'll review the source compat results.

@ematejska
Copy link
Contributor Author

@swift-ci Please Test Source Compatibility

@ematejska
Copy link
Contributor Author

ematejska commented May 3, 2017 •
edited
Loading

@tkremenek: All the tests that failed in the source compat suite were xfailed in a followup run and the errors are unrelated. The kickstarter issue seems to be rdar://problem/30788078. The other issues Xfailed are https://bugs.swift.org/browse/SR-4731, https://bugs.swift.org/browse/SR-4730, https://bugs.swift.org/browse/SR-4709, https://bugs.swift.org/browse/SR-4705, https://bugs.swift.org/browse/SR-4696

@ematejska ematejska merged commit 5bd63fe into swift-4.0-branch May 3, 2017
@tkremenek tkremenek deleted the Merge-9098-4-branch branch May 3, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ematejska @tkremenek