[frontend] Add 'finishProcessing()' method for DiagnosticConsumers to do their finalization (e.g. writing to a file) #9222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
jrose-apple
reviewed
May 3, 2017
lib/AST/DiagnosticEngine.cpp
Outdated
| bool DiagnosticEngine::finishProcessing() { | ||
| bool hadError = false; | ||
| for (auto &Consumer : Consumers) { | ||
| hadError = Consumer->finishProcessing() || hadError; |
| EC, | ||
| llvm::sys::fs::F_None)); | ||
| if (EC) { | ||
| // Create a temporary diagnostics engine to print the error to stderr. |
There was a problem hiding this comment.
I feel like there should be some shorter way to do this, since you have it twice. But that can happen later.
lib/FrontendTool/FrontendTool.cpp
Outdated
| DiagnosticEngine DE(dummyMgr); | ||
| PrintingDiagnosticConsumer PDC; | ||
| DE.addConsumer(PDC); | ||
| DE.diagnose(SourceLoc(), diag::cannot_open_serialized_file, |
There was a problem hiding this comment.
This should be "cannot_open_file", right?
|
This is blocked on #9260 |
… do their finalization (e.g. writing to a file) Use this to avoid creating an empty serialized diagnostics file when the compiler crashes.
akyrtzi
force-pushed
the
serialized-diagnostics-file
branch
from
4f66f63 to
0bb299a
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this to avoid creating an empty serialized diagnostics file when the compiler crashes.