Update reflection on 4.0 to match code in master #9242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
reflection-syncup-4.0
branch
from
d64ef31 to
9150a9b
Compare
…ld type does not demangle Better to fail instead of producing an invalid layout.
…ed type of AnyObject The "superclass as associated type" modeling was put in to maintain backward compatibility. We just bumped the version number because of new mangling so we may as well fix this sillyness too.
…otocol member Fixes <rdar://problem/31661662>, <rdar://problem/31668126>, and probably many other crashes with the same backtrace.
I don't have a test case, but this will address the crashes in <rdar://problem/30398155> and <rdar://problem/31961386>.
slavapestov
force-pushed
the
reflection-syncup-4.0
branch
from
9150a9b to
1494564
Compare
|
@swift-ci Please test |
|
@bitjammer @rjmccall Can you please review this for 4.0? |
|
I'm out and about right now but will take a look when I get home tonight. |
bitjammer
approved these changes
May 5, 2017
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Scope of the issue: the top crashes have been coming up a lot, and subclass existential support in reflection is important because this is a new feature we just introduced.
Origination: The crash with private protocols was introduced by the RemoteAST work done in Swift 3.1, so it is a regression from Swift 3.0 to 3.1. The support for subclass existentials is needed because subclass existentials were introduced in 4.0.
Risk: Very low risk for anything other than reflection. Medium risk for reflection since there is a lot of new code; I would have liked to get it in two days ago, but was hitting CI issues and I'm hoping it should not be a problem to get it in now.
Tested: New tests added for the new features and bug fixes.
Reviewed by: @bitjammer and @rjmccall