[Associated type inference] Check solutions against full requirement signature #9275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this routine suppress diagnostics when there is no source-location information (which allows it to be used as a query) and to distinguish the "we couldn't substitute into a requirement" failure mode from the "a requirement actually failed" failure mode.
Extend SubstOptions, which controls how substitution is performed, to allow the caller to subst() to provide a callback function that may provide a type witness for a normal protocol conformance that is undergoing type witness inference. In effect, it's allowing us to provide tentative bindings for type witnesses so we can see the effects of substitution.
…signature When we have a potential assignment of associated types to type witnesses during associated type inference, check that set of type witnesses against the requirements in the requirement signature, so that we can reject any solutions that fail some of the protocol's requirements. This is most of rdar://problem/31830524 --- but gets thwarted by the inability of associated type inference to work across multiple protocols.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a potential assignment of associated types to type
witnesses during associated type inference, check that set of type
witnesses against the requirements in the requirement signature, so
that we can reject any solutions that fail some of the protocol's
requirements.
This is most of rdar://problem/31830524 --- but gets thwarted by the
inability of associated type inference to work across multiple
protocols.