GitHub merge Migrator -> swift 4.0 branch #9277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CompilerInstance will be used if a fix-it run created an error-free AST that we can continue to use in the AST passes. rdar://problem/31926195
With SE-110, the migrator may get a recommendation to add a Void placeholder in the call to f in: func foo(f: (Void) -> ()) { f() } Here, f was () -> () in Swift 3 but now (()) -> () in Swift 4. Adding a type placeholder in the f() call isn't helpful for migration, although this particular fix-it should be to fix the f parameter's type. rdar://problem/31895432
There is no implicit conversion between String and Substring, so the migrator can offer fix-its to convert between the two by wrapping in String.init or adding the void subscript [] accordingly. This commit just adds the tests for migration for the time being. rdar://problem/30928902
bitjammer
changed the title
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to cherry-pick these after the branch on Monday.
rdar://problem/31895432