Fixes a bug in large loadable types wherein only the callee type of Apply is changed #9290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aschwaighofer Can you please review? |
|
@swift-ci Please smoke test |
shajrawi
pushed a commit
that referenced
this pull request
May 4, 2017
Fixes a bug in large loadable types wherein only the callee type of Apply is changed
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radar rdar://problem/31991715
Fixes a corner-case in large loadable types: An apply instruction wherein neither the parameters nor the return type is changed BUT The callee signature is changed (a method inside a class) - need to re-create the Apply instruction in that case.