[Parser] Add fix-it for missing type errors #9294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't reliably decide in the parser if a type was forgotten or a wrong type was meant to be a type (e.g. `let x: class MyClass`). This patch applies a heuristic that the parameter was most likely forgotten if the next character is a closing bracket or a semantic separator. This catches the most common cases of function parameters and variable declarations that are immediately initialised. This fixes SR-4785.
|
@swift-ci please smoke test |
jrose-apple
approved these changes
May 19, 2017
| // If the next token is closing or separating, the type was likely forgotten | ||
| if (Tok.isAny(tok::r_paren, tok::r_brace, tok::r_square, tok::arrow, | ||
| tok::equal, tok::comma, tok::semi)) { | ||
| diag.fixItInsert(getEndOfPreviousLoc(), " <#type#>"); |
There was a problem hiding this comment.
This isn't perfect because the space isn't always needed, but I can't think of a way to test whether it's needed without looking at the previous token, which is a bit tricky. I guess this is good enough!
|
Re-smoke-testing just in case, since it's been two weeks. @swift-ci Please smoke test |
|
Thanks for the review |
jtbandes
added a commit
that referenced
this pull request
May 27, 2017
Fixes @practicalswift's crasher 28759 (#9907), which seems to have been introduced in #9294.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-4785.
We can't reliably decide in the parser if a type was forgotten or a wrong spelling was meant to be a type (e.g.
let x: class MyClass). This patch applies a heuristic that the parameter was most likely forgotten if the next character is a closing bracket or a semantic separator (arrow, equal, comma, semicolon).This catches the most common cases of function parameters and variable declarations that are immediately initialised.