Skip to content

[4.0] Switch on key paths. #9304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2017
Merged

[4.0] Switch on key paths. #9304

merged 1 commit into from
May 5, 2017

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented May 4, 2017

Explanation: Turns on the key path feature, now that the proposal has been accepted and an initial implementation is in place.

Scope: New feature.

Issue: rdar://problem/30957490

Risk: Low. Though this is a major new feature, there's little to no interaction with code that does not take advantage of it.

Testing: Swift CI

@jckarter
Copy link
Contributor Author

jckarter commented May 4, 2017

@swift-ci Please test

@jckarter
Copy link
Contributor Author

jckarter commented May 4, 2017

@ematejska Requesting your review to enable keypaths in 4.0—are we all good?

@jckarter jckarter requested a review from ematejska May 4, 2017 23:32
@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - fc94b4ad93296e85d0e5767d0d1ea7c3b9e09c8a
Test requested by - @jckarter

@jckarter jckarter force-pushed the enable-keypaths-4.0 branch from fc94b4a to d98d7c2 Compare May 5, 2017 00:33
@jckarter
Copy link
Contributor Author

jckarter commented May 5, 2017

@swift-ci Please test

@jckarter
Copy link
Contributor Author

jckarter commented May 5, 2017

@swift-ci Please smoke test

@jckarter
Copy link
Contributor Author

jckarter commented May 5, 2017

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - d98d7c28a5d8506336de09ea2c3b28d82d19b7e0
Test requested by - @jckarter

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d98d7c28a5d8506336de09ea2c3b28d82d19b7e0
Test requested by - @jckarter

@shahmishal shahmishal added this to the Swift 4.0 milestone May 5, 2017
@jckarter
Switch on key paths.
2b548ca 
Enabling the global subscript degrades some diagnostics (rdar://problem/31724211).
@jckarter jckarter force-pushed the enable-keypaths-4.0 branch from d98d7c2 to 2b548ca Compare May 5, 2017 15:34
@jckarter
Copy link
Contributor Author

jckarter commented May 5, 2017

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d98d7c28a5d8506336de09ea2c3b28d82d19b7e0
Test requested by - @jckarter

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - d98d7c28a5d8506336de09ea2c3b28d82d19b7e0
Test requested by - @jckarter

@jckarter
Copy link
Contributor Author

jckarter commented May 5, 2017

@swift-ci Please test

@jckarter jckarter merged commit c050e38 into swiftlang:swift-4.0-branch May 5, 2017
@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 2b548ca
Test requested by - @jckarter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematejska ematejska ematejska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Swift 4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jckarter @swift-ci @ematejska @shahmishal