[Migrator] Suggest String <-> Substring conversions #9314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some APIs that expected a String now expect a Substring and vice versa. To ease the transition, emit fix-its on conversion errors between these types that the migrator can pick up. When converting from Substring -> String, suggest wrapping in `String.init`. When converting from String -> Substring, suggest appending the void subscript `[]`. (This isn't implemented yet so this is hidden behind a flag). This can possibly be generalized later when converting between some sequence and its subsequence, such as Array and ArraySlice, for example. rdar://problem/31665649 rdar://problem/31666638
|
Swift-4.0-branch cherry-pick of #9307 |
|
@swift-ci Please test |
|
Build failed |
|
Looks like the node timed out during swiftpm tests. I'll try again. |
|
@swift-ci Please test |
|
All good now. |
bitjammer
deleted the
rdar-31665649-migrator-string-substring-swift-4.0-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some APIs that expected a String now expect a Substring and vice
versa. To ease the transition, emit fix-its on conversion errors
between these types that the migrator can pick up.
When converting from Substring -> String, suggest wrapping in
String.init.When converting from String -> Substring, suggest appending the
void subscript
[]. (This isn't implemented yet so this ishidden behind a flag).
This can possibly be generalized later when converting between
some sequence and its subsequence, such as Array and ArraySlice,
for example.
rdar://problem/31665649
rdar://problem/31666638