Change getBaseName to return DeclBaseName instead of Identifier #9321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2017
|
Please test with following pull request: @swift-ci Please test |
Printing a declaration's name using `<<` and `getBaseName()` is be independent of the return type of `getBaseName()` which will change in the future from `Identifier` to `DeclBaseName`
Printing a declaration's name using `<<` and `getBaseName()` is be independent of the return type of `getBaseName()` which will change in the future from `Identifier` to `DeclBaseName`
|
Build failed |
|
Build failed |
|
Please test with following pull request: @swift-ci Please test |
This changes `getBaseName()` on `DeclName` to return a `DeclBaseName` instead of an `Identifier`. All places that will continue to be expecting an `Identifier` are changed to call `getBaseIdentifier` which will later assert that the `DeclName` is actually backed by an identifier and not a special name. For transitional purposes, a conversion operator from `DeclBaseName` to `Identifier` has been added that will be removed again once migration to DeclBaseName has been completed in other parts of the compiler.
|
Please test with following pull request: @swift-ci Please test |
|
Rebased and merged in #9968. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
getBaseName()onDeclNameto return aDeclBaseNameinstead of an
Identifier. All places that will continue to beexpecting an
Identifierare changed to callgetBaseIdentifierwhichwill later assert that the
DeclNameis actually backed by anidentifier and not a special name.
For transitional purposes, a conversion operator from
DeclBaseNametoIdentifierhas been added that will be removed again once migrationto DeclBaseName has been completed in other parts of the compiler.
This PR depends on (and includes the changes from) #9319 and #9320