Revert "[StdLib] Extend ReflectionHashing test to pass on Linux" #933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test expects consistent hash code generation on any given platform.
However String instance generate different values on Linux depending on which
version of libicu is installed, causing environment-specific test failures.
This reverts commit def419b.
The specific situation here is that we're relying on libicu's collation elements to hash strings on platforms without objective-c interop. The values for collection elements returned by icu vary depending upon the specific version of ICU, the internal collation algorithm, and the version of Unicode that's being implemented. As a result, I don't seem to be able to mimic the other tests by checking for a static answer.
I've validated this in versions 52 (in Ubuntu 14.04) and 54 (in Fedora 23). I haven't yet tried on Ubuntu 15.10, but I expect it to be from 14.04.
@moiseev @gribozavr Can either of you tell me more about this test? Is reliance on stable hashing instrumental in this test's intent or just an implementation side effect?